]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
target: Don't return success from module_init() if setup fails
authorRoland Dreier <roland@purestorage.com>
Wed, 31 Oct 2012 16:16:44 +0000 (09:16 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Nov 2012 21:14:20 +0000 (13:14 -0800)
commitf100fdf3a97be683cf57802a566cfe0cce89fc7a
treed10dbb57618dbb5c3e5e9a08bbc22c857f089a63
parent4a7dfa5ea7f7a4736ba9425cbd343d0eb18f521f
target: Don't return success from module_init() if setup fails

commit 0d0f9dfb31e0a6c92063e235417b42df185b3275 upstream.

If the call to core_dev_release_virtual_lun0() fails, then nothing
sets ret to anything other than 0, so even though everything is
torn down and freed, target_core_init_configfs() will seem to succeed
and the module will be loaded.  Fix this by passing the return value
on up the chain.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/target_core_configfs.c