]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ARM: arch_timer: Silence debug preempt warnings
authorStephen Boyd <sboyd@codeaurora.org>
Wed, 17 Apr 2013 23:26:18 +0000 (16:26 -0700)
committerOlof Johansson <olof@lixom.net>
Sat, 27 Apr 2013 00:17:29 +0000 (17:17 -0700)
commitf31c2f1c68aff83277eddc6798adf3438e9c680a
tree2019d040fe052e6979ebd211f12ec377da5f5c1e
parent405f5e5ee53339cf5d5d1753f8614938b1222562
ARM: arch_timer: Silence debug preempt warnings

Hot-plugging with CONFIG_DEBUG_PREEMPT=y on a device with arm
architected timers causes a slew of "using smp_processor_id() in
preemptible" warnings:

  BUG: using smp_processor_id() in preemptible [00000000] code: sh/111
  caller is arch_timer_cpu_notify+0x14/0xc8

This happens because sometimes the cpu notifier,
arch_timer_cpu_notify(), is called in preemptible context and
other times in non-preemptible context but we use this_cpu_ptr()
to retrieve the clockevent in all cases. We're only going to
actually use the pointer in non-preemptible context though, so
push the this_cpu_ptr() access down into the cases to force the
checks to occur only in non-preemptible contexts.

Cc: John Stultz <john.stultz@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>
Acked-by: Marc Zyngier <Marc.Zyngier@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
drivers/clocksource/arm_arch_timer.c