]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
um: Avoid longjmp/setjmp symbol clashes with libpthread.a
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 24 May 2017 00:32:31 +0000 (17:32 -0700)
committerRichard Weinberger <richard@nod.at>
Wed, 5 Jul 2017 21:30:50 +0000 (23:30 +0200)
commitf44f1e7da7c8e3f4575d5d61c4df978496903fcc
tree237c2be6138a7d6aa516989a85f144e14891ec69
parent745a600cf1a6230f5e3910c340dcb312b718e114
um: Avoid longjmp/setjmp symbol clashes with libpthread.a

Building a statically linked UML kernel on a Centos 6.9 host resulted in
the following linking failure (GCC 4.4, glibc-2.12):

/usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../lib64/libpthread.a(libpthread.o):
In function `siglongjmp':
(.text+0x8490): multiple definition of `longjmp'
arch/x86/um/built-in.o:/local/users/fainelli/openwrt/trunk/build_dir/target-x86_64_musl/linux-uml/linux-4.4.69/arch/x86/um/setjmp_64.S:44:
first defined here
/usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../lib64/libpthread.a(libpthread.o):
In function `sem_open':
(.text+0x77cd): warning: the use of `mktemp' is dangerous, better use
`mkstemp'
collect2: ld returned 1 exit status
make[4]: *** [vmlinux] Error 1

Adopt a solution similar to the one done for vmap where we define
longjmp/setjmp to be kernel_longjmp/setjmp. In the process, make sure we
do rename the functions in arch/x86/um/setjmp_*.S accordingly.

Fixes: a7df4716d195 ("um: link with -lpthread")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/Makefile
arch/x86/um/setjmp_32.S
arch/x86/um/setjmp_64.S