]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
USB: cdc-acm: Fixing crash when ACM probing interfaces with no endpoint descriptors.
authorToby Gray <toby.gray@realvnc.com>
Thu, 2 Sep 2010 09:46:20 +0000 (10:46 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 20 Sep 2010 20:36:23 +0000 (13:36 -0700)
commitf723b548653996b6e7dfbabd8e431e3fd1dc3c17
tree6a868f1ed9efa60ba2afc9e5ac315a021731b839
parent67584f5e2e19499c8484991684110730080d7221
USB: cdc-acm: Fixing crash when ACM probing interfaces with no endpoint descriptors.

commit 577045c0a76e34294f902a7d5d60e90b04d094d0 upstream.

Certain USB devices, such as the Nokia X6 mobile phone, don't expose any
endpoint descriptors on some of their interfaces. If the ACM driver is forced
to probe all interfaces on a device the a NULL pointer dereference will occur
when the ACM driver attempts to use the endpoint of the alternative settings.
One way to get the ACM driver to probe all the interfaces is by using the
/sys/bus/usb/drivers/cdc_acm/new_id interface.

This patch checks that the endpoint pointer for the current alternate settings
is non-NULL before using it.

Signed-off-by: Toby Gray <toby.gray@realvnc.com>
Cc: Oliver Neukum <oliver@neukum.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/class/cdc-acm.c