]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
gpio: mvebu: fix gpio bank registration when pwm is used
authorRichard Genoud <richard.genoud@gmail.com>
Thu, 1 Jun 2017 12:18:26 +0000 (14:18 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 9 Jun 2017 07:38:27 +0000 (09:38 +0200)
commitfc7a90686777e7d2da7a08cf0202c21f3b96febb
tree3da8fd5d68eb64b67e583c2c936ce87db82abe5d
parentc528eb27a3be2600e724c8a57cb69eab1fd9afa2
gpio: mvebu: fix gpio bank registration when pwm is used

If more than one gpio bank has the "pwm" property, only one will be
registered successfully, all the others will fail with:
mvebu-gpio: probe of f1018140.gpio failed with error -17

That's because in alloc_pwms(), the chip->base (aka "int pwm"), was not
set (thus, ==0) ; and 0 is a meaningful start value in alloc_pwm().
What was intended is mvpwm->chip->base = -1.
Like that, the numbering will be done auto-magically

Moreover, as the region might be already occupied by another pwm, we
shouldn't force:
mvpwm->chip->base = 0
nor
mvpwm->chip->base = id * MVEBU_MAX_GPIO_PER_BANK;

Tested on clearfog-pro (Marvell 88F6828)

Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mvebu.c