]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mwifiex: printk() overflow with 32-byte SSIDs
authorBrian Norris <briannorris@chromium.org>
Wed, 9 Nov 2016 02:28:24 +0000 (18:28 -0800)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 17 Nov 2016 11:16:52 +0000 (13:16 +0200)
commitfcd2042e8d36cf644bd2d69c26378d17158b17df
tree146628560492e422224c678ccb41343bdae64c26
parentd3532ea6ce4ea501e421d130555e59edc2945f99
mwifiex: printk() overflow with 32-byte SSIDs

SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length
when we print them out.

This can be easily noticed by connecting to a network with a 32-octet
SSID:

[ 3903.502925] mwifiex_pcie 0000:01:00.0: info: trying to associate to
'0123456789abcdef0123456789abcdef <uninitialized mem>' bssid
xx:xx:xx:xx:xx:xx

Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Cc: <stable@vger.kernel.org>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/cfg80211.c