ENGR00291400 PXP: Organize PXP task queue to be FIFO

The requested PXP tasks were handled based on channel unit. All the
tasks in one channel were handled one by one, and the tasks in another
channel only can get chance after all the tasks in previous channel
were finished. So this may allow some channel occupies PXP hardware
exclusively all the time, and other channels may never get PXP services.
So this change makes the PXP task queue to be a FIFO to avoid this kind
of unfair usage for PXP.

Signed-off-by: Fancy Fang <B47543@freescale.com>

diff --git a/drivers/dma/pxp/pxp_dma_v2.c b/drivers/dma/pxp/pxp_dma_v2.c
index 28fe2046858bcf9200ffbc272157814592b6536e..30d6a14e20ce4e8c3595e9128ace4d094c774599 100644 (file)
--- a/drivers/dma/pxp/pxp_dma_v2.c
+++ b/drivers/dma/pxp/pxp_dma_v2.c
@@ -1060,11 +1060,6 @@ static void pxp_clkoff_timer(unsigned long arg)
                          jiffies + msecs_to_jiffies(timeout_in_ms));
 }
 
-static struct pxp_tx_desc *pxpdma_first_active(struct pxp_channel *pxp_chan)
-{
-       return list_entry(pxp_chan->active_list.next, struct pxp_tx_desc, list);
-}
-
 static struct pxp_tx_desc *pxpdma_first_queued(struct pxp_channel *pxp_chan)
 {
        return list_entry(pxp_chan->queue.next, struct pxp_tx_desc, list);
@@ -1079,9 +1074,8 @@ static void __pxpdma_dostart(struct pxp_channel *pxp_chan)
        struct pxp_tx_desc *child;
        int i = 0;
 
-       /* so far we presume only one transaction on active_list */
        /* S0 */
-       desc = pxpdma_first_active(pxp_chan);
+       desc = list_first_entry(&head, struct pxp_tx_desc, list);
        memcpy(&pxp->pxp_conf_state.s0_param,
               &desc->layer_param.s0_param, sizeof(struct pxp_layer_param));
        memcpy(&pxp->pxp_conf_state.proc_data,
@@ -1114,7 +1108,8 @@ static void __pxpdma_dostart(struct pxp_channel *pxp_chan)
 static void pxpdma_dostart_work(struct pxps *pxp)
 {
        struct pxp_channel *pxp_chan = NULL;
-       unsigned long flags, flags1;
+       unsigned long flags;
+       struct pxp_tx_desc *desc = NULL;
 
        spin_lock_irqsave(&pxp->lock, flags);
        if (list_empty(&head)) {
@@ -1123,16 +1118,10 @@ static void pxpdma_dostart_work(struct pxps *pxp)
                return;
        }
 
-       pxp_chan = list_entry(head.next, struct pxp_channel, list);
+       desc = list_entry(head.next, struct pxp_tx_desc, list);
+       pxp_chan = to_pxp_channel(desc->txd.chan);
 
-       spin_lock_irqsave(&pxp_chan->lock, flags1);
-       if (!list_empty(&pxp_chan->active_list)) {
-               struct pxp_tx_desc *desc;
-               /* REVISIT */
-               desc = pxpdma_first_active(pxp_chan);
-               __pxpdma_dostart(pxp_chan);
-       }
-       spin_unlock_irqrestore(&pxp_chan->lock, flags1);
+       __pxpdma_dostart(pxp_chan);
 
        /* Configure PxP */
        pxp_config(pxp, pxp_chan);
@@ -1203,7 +1192,6 @@ static int pxp_init_channel(struct pxp_dma *pxp_dma,
         * (i.e., pxp_tx_desc) here.
         */
 
-       INIT_LIST_HEAD(&pxp_chan->active_list);
        INIT_LIST_HEAD(&pxp_chan->queue);
 
        return ret;
@@ -1235,18 +1223,9 @@ static irqreturn_t pxp_irq(int irq, void *dev_id)
                return IRQ_NONE;
        }
 
-       pxp_chan = list_entry(head.next, struct pxp_channel, list);
-
-       if (list_empty(&pxp_chan->active_list)) {
-               pr_debug("PXP_IRQ pxp_chan->active_list empty. chan_id %d\n",
-                        pxp_chan->dma_chan.chan_id);
-               pxp->pxp_ongoing = 0;
-               spin_unlock_irqrestore(&pxp->lock, flags);
-               return IRQ_NONE;
-       }
-
        /* Get descriptor and call callback */
-       desc = pxpdma_first_active(pxp_chan);
+       desc = list_entry(head.next, struct pxp_tx_desc, list);
+       pxp_chan = to_pxp_channel(desc->txd.chan);
 
        pxp_chan->completed = desc->txd.cookie;
 
@@ -1268,9 +1247,6 @@ static irqreturn_t pxp_irq(int irq, void *dev_id)
        list_del_init(&desc->list);
        kmem_cache_free(tx_desc_cache, (void *)desc);
 
-       if (list_empty(&pxp_chan->active_list))
-               list_del_init(&pxp_chan->list);
-
        complete(&pxp->complete);
        pxp->pxp_ongoing = 0;
        mod_timer(&pxp->clk_timer, jiffies + msecs_to_jiffies(timeout_in_ms));
@@ -1374,30 +1350,13 @@ static void pxp_issue_pending(struct dma_chan *chan)
        struct pxp_dma *pxp_dma = to_pxp_dma(chan->device);
        struct pxps *pxp = to_pxp(pxp_dma);
        unsigned long flags0, flags;
-       struct list_head *iter;
 
        spin_lock_irqsave(&pxp->lock, flags0);
        spin_lock_irqsave(&pxp_chan->lock, flags);
 
        if (!list_empty(&pxp_chan->queue)) {
-               pxpdma_dequeue(pxp_chan, &pxp_chan->active_list);
+               pxpdma_dequeue(pxp_chan, &head);
                pxp_chan->status = PXP_CHANNEL_READY;
-               iter = head.next;
-               /* Avoid adding a pxp channel to head list which
-                * has been already listed in it. And this may
-                * cause the head list to be broken down.
-                */
-               if (list_empty(&head)) {
-                       list_add_tail(&pxp_chan->list, &head);
-               } else {
-                       while (iter != &head) {
-                               if (&pxp_chan->list == iter)
-                                       break;
-                               iter = iter->next;
-                       }
-                       if (iter == &head)
-                               list_add_tail(&pxp_chan->list, &head);
-               }
        } else {
                spin_unlock_irqrestore(&pxp_chan->lock, flags);
                spin_unlock_irqrestore(&pxp->lock, flags0);

diff --git a/include/linux/pxp_dma.h b/include/linux/pxp_dma.h
index 7cb5436a575e4821d6f0e950d837c009e2ba32c9..41c8a39042c32f443c9202b71e7e2401455cc4ca 100644 (file)
--- a/include/linux/pxp_dma.h
+++ b/include/linux/pxp_dma.h
@@ -45,7 +45,6 @@ struct pxp_channel {
        void *client;           /* Only one client per channel */
        unsigned int n_tx_desc;
        struct pxp_tx_desc *desc;       /* allocated tx-descriptors */
-       struct list_head active_list;   /* active tx-descriptors */
        struct list_head queue; /* queued tx-descriptors */
        struct list_head list;  /* track queued channel number */
        spinlock_t lock;        /* protects sg[0,1], queue */