]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[media] vcodec: mediatek: Remove double parentheses
authorMatthias Kaehlcke <mka@chromium.org>
Fri, 17 Mar 2017 21:01:33 +0000 (18:01 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 5 Apr 2017 18:09:20 +0000 (15:09 -0300)
The extra pairs of parentheses are not needed and cause clang
warnings like this:

drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
                if ((inst->work_bufs[i].size == 0))
                     ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: note: remove extraneous parentheses around the comparison to silence this warning
                if ((inst->work_bufs[i].size == 0))
                    ~                        ^   ~
drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: note: use '=' to turn this equality comparison into an assignment
                if ((inst->work_bufs[i].size == 0))
                                             ^~
                                             =

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c

index a6fa145f2c54e201937b3bab5e76197294b786cc..acb639c4abd2b65c3b59e244c671f6981b9ef790 100644 (file)
@@ -155,7 +155,7 @@ static void vp8_enc_free_work_buf(struct venc_vp8_inst *inst)
 
        /* Buffers need to be freed by AP. */
        for (i = 0; i < VENC_VP8_VPU_WORK_BUF_MAX; i++) {
-               if ((inst->work_bufs[i].size == 0))
+               if (inst->work_bufs[i].size == 0)
                        continue;
                mtk_vcodec_mem_free(inst->ctx, &inst->work_bufs[i]);
        }
@@ -172,7 +172,7 @@ static int vp8_enc_alloc_work_buf(struct venc_vp8_inst *inst)
        mtk_vcodec_debug_enter(inst);
 
        for (i = 0; i < VENC_VP8_VPU_WORK_BUF_MAX; i++) {
-               if ((wb[i].size == 0))
+               if (wb[i].size == 0)
                        continue;
                /*
                 * This 'wb' structure is set by VPU side and shared to AP for