]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
__send_signal: pass q->info, not info, to userns_fixup_signal_uid (v2)
authorSerge Hallyn <serge.hallyn@canonical.com>
Fri, 16 Dec 2011 04:50:47 +0000 (15:50 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 20 Dec 2011 07:44:08 +0000 (18:44 +1100)
Eric Biederman pointed out that passing info is a bug and could lead to a
NULL pointer deref to boot.

A collection of signal, securebits, filecaps, cap_bounds, and a few other
ltp tests passed with this kernel.

Changelog:
    Nov 18: previous patch missed a leading '&'

Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/signal.c

index 13c2349d95d6d0893550aec39c096e69a3a38189..2daed3188118d43470500be91248b6414b3caf80 100644 (file)
@@ -1118,7 +1118,7 @@ static int __send_signal(int sig, struct siginfo *info, struct task_struct *t,
                        break;
                }
 
-               userns_fixup_signal_uid(info, t);
+               userns_fixup_signal_uid(&q->info, t);
 
        } else if (!is_si_special(info)) {
                if (sig >= SIGRTMIN && info->si_code != SI_USER) {