]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
perf tools: Fix a memory leak in __open_dso()
authorNamhyung Kim <namhyung@kernel.org>
Thu, 8 Jun 2017 07:31:02 +0000 (16:31 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 8 Jun 2017 18:38:47 +0000 (15:38 -0300)
The 'name' variable should be freed on the error path.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: kernel-team@lge.com
Link: http://lkml.kernel.org/r/20170608073109.30699-3-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/dso.c

index b27d127cdf68f996ee4f96ce24aa51044e31bf9f..1f29e4fe7af08e6faa766ea63ed08540e955620a 100644 (file)
@@ -412,8 +412,10 @@ static int __open_dso(struct dso *dso, struct machine *machine)
                return -EINVAL;
        }
 
-       if (!is_regular_file(name))
+       if (!is_regular_file(name)) {
+               free(name);
                return -EINVAL;
+       }
 
        fd = do_open(name);
        free(name);