]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
platform/x86: toshiba_acpi: constify attribute_group structures.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 11 Jul 2017 10:48:20 +0000 (16:18 +0530)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 11 Jul 2017 16:22:55 +0000 (09:22 -0700)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
  26360    1072      24   27456    6b40 drivers/platform/x86/toshiba_acpi.o

File size After adding 'const':
   text    data     bss     dec     hex filename
  26424    1008      24   27456    6b40 drivers/platform/x86/toshiba_acpi.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/toshiba_acpi.c

index 88f9f79a7cf605ce6d8624d4f3f6826854cf0796..bb1dcd7fbdeb81902f8b9a395569d1101c342fae 100644 (file)
@@ -2419,7 +2419,7 @@ static umode_t toshiba_sysfs_is_visible(struct kobject *kobj,
        return exists ? attr->mode : 0;
 }
 
-static struct attribute_group toshiba_attr_group = {
+static const struct attribute_group toshiba_attr_group = {
        .is_visible = toshiba_sysfs_is_visible,
        .attrs = toshiba_attributes,
 };