mtd: nand: complain loudly when chip->bits_per_cell is not correctly initialized

chip->bits_per_cell which is used to determine the NAND cell type
(SLC/MLC) should always have a value != 0.
Complain loudly if the value is 0 in nand_is_slc() to catch use before
correct initialization.

diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 5216d2eb22891010187b86a5911a10b17aedf273..14761eb01e560100ad19d6e1648632da8e56a782 100644 (file)
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -1246,6 +1246,8 @@ int onfi_init_data_interface(struct nand_chip *chip,
  */
 static inline bool nand_is_slc(struct nand_chip *chip)
 {
  */
 static inline bool nand_is_slc(struct nand_chip *chip)
 {

+       WARN(chip->bits_per_cell == 0,
+            "chip->bits_per_cell is used uninitialized\n");

        return chip->bits_per_cell == 1;
 }
 
        return chip->bits_per_cell == 1;
 }