]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
xen: make use of xenbus_read_unsigned() in xen-pciback
authorJuergen Gross <jgross@suse.com>
Mon, 31 Oct 2016 13:58:41 +0000 (14:58 +0100)
committerJuergen Gross <jgross@suse.com>
Mon, 7 Nov 2016 12:55:34 +0000 (13:55 +0100)
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
This requires to change the type of the read from int to unsigned,
but this case has been wrong before: negative values are not allowed
for the modified case.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: David Vrabel <david.vrabel@citrix.com>
drivers/xen/xen-pciback/xenbus.c

index 5ce878c51d034d71952b1da2697c2bb469655461..3f0aee0a068b213803b4a4a3a771c1285562b43e 100644 (file)
@@ -362,7 +362,7 @@ static int xen_pcibk_reconfigure(struct xen_pcibk_device *pdev)
        int err = 0;
        int num_devs;
        int domain, bus, slot, func;
-       int substate;
+       unsigned int substate;
        int i, len;
        char state_str[64];
        char dev_str[64];
@@ -395,10 +395,8 @@ static int xen_pcibk_reconfigure(struct xen_pcibk_device *pdev)
                                         "configuration");
                        goto out;
                }
-               err = xenbus_scanf(XBT_NIL, pdev->xdev->nodename, state_str,
-                                  "%d", &substate);
-               if (err != 1)
-                       substate = XenbusStateUnknown;
+               substate = xenbus_read_unsigned(pdev->xdev->nodename, state_str,
+                                               XenbusStateUnknown);
 
                switch (substate) {
                case XenbusStateInitialising: