]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
serial: pch_uart: trivail cleanup by removing the pch_uart_hal_request()
authorFeng Tang <feng.tang@intel.com>
Mon, 6 Feb 2012 09:24:45 +0000 (17:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2012 17:02:26 +0000 (09:02 -0800)
pch_uart_hal_request() has parameters which it never uses, also
it is very short, so merge it with its caller to make code cleaner.
No functional changes at all.

Signed-off-by: Feng Tang <feng.tang@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pch_uart.c

index 811edcbe73040887e3fea489ffb11e79d99c0a55..aa4d07b4a9d505ea0cc8f78a8e01c9c051561a03 100644 (file)
@@ -364,15 +364,6 @@ static const struct file_operations port_regs_ops = {
 };
 #endif /* CONFIG_DEBUG_FS */
 
-static void pch_uart_hal_request(struct pci_dev *pdev, int fifosize,
-                                int base_baud)
-{
-       struct eg20t_port *priv = pci_get_drvdata(pdev);
-
-       priv->trigger_level = 1;
-       priv->fcr = 0;
-}
-
 static void pch_uart_hal_enable_interrupt(struct eg20t_port *priv,
                                          unsigned int flag)
 {
@@ -1674,7 +1665,8 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev,
        spin_lock_init(&priv->port.lock);
 
        pci_set_drvdata(pdev, priv);
-       pch_uart_hal_request(pdev, fifosize, base_baud);
+       priv->trigger_level = 1;
+       priv->fcr = 0;
 
 #ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
        pch_uart_ports[board->line_no] = priv;
@@ -1717,9 +1709,7 @@ static void pch_uart_exit_port(struct eg20t_port *priv)
 
 static void pch_uart_pci_remove(struct pci_dev *pdev)
 {
-       struct eg20t_port *priv;
-
-       priv = (struct eg20t_port *)pci_get_drvdata(pdev);
+       struct eg20t_port *priv = pci_get_drvdata(pdev);
 
        pci_disable_msi(pdev);