]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
KVM: Fix apic_mmio_write return for unaligned write
authorSheng Yang <sheng@linux.intel.com>
Mon, 6 Jul 2009 03:05:39 +0000 (11:05 +0800)
committerAvi Kivity <avi@redhat.com>
Thu, 10 Sep 2009 05:33:08 +0000 (08:33 +0300)
Some in-famous OS do unaligned writing for APIC MMIO, and the return value
has been missed in recent change, then the OS hangs.

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/lapic.c

index 683345a121b73ddf08ad692e8a38df7d9a20a21e..6c8460308548ac237d1d67c65c3a3c8b81b0eca7 100644 (file)
@@ -834,7 +834,7 @@ static int apic_mmio_write(struct kvm_io_device *this,
        if (len != 4 || (offset & 0xf)) {
                /* Don't shout loud, $infamous_os would cause only noise. */
                apic_debug("apic write: bad size=%d %lx\n", len, (long)address);
-               return;
+               return 0;
        }
 
        val = *(u32*)data;