]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[SCSI] sd: don't fail if the device doesn't recognize SYNCHRONIZE CACHE
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 15 Jan 2014 20:37:04 +0000 (15:37 -0500)
committerJames Bottomley <JBottomley@Parallels.com>
Sat, 15 Mar 2014 17:19:22 +0000 (10:19 -0700)
Evidently some wacky USB-ATA bridges don't recognize the SYNCHRONIZE
CACHE command, as shown in this email thread:

http://marc.info/?t=138978356200002&r=1&w=2

The fact that we can't tell them to drain their caches shouldn't
prevent the system from going into suspend.  Therefore sd_sync_cache()
shouldn't return an error if the device replies with an Invalid
Command ASC.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Sven Neumann <s.neumann@raumfeld.com>
Tested-by: Daniel Mack <zonque@gmail.com>
CC: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/sd.c

index 470954aba7289a758a650cd82b2f1dfe50ae54f1..36d1a23f14be911b5171f2345e1a87553517e4ef 100644 (file)
@@ -1463,8 +1463,8 @@ static int sd_sync_cache(struct scsi_disk *sdkp)
                        sd_print_sense_hdr(sdkp, &sshdr);
                /* we need to evaluate the error return  */
                if (scsi_sense_valid(&sshdr) &&
-                       /* 0x3a is medium not present */
-                       sshdr.asc == 0x3a)
+                       (sshdr.asc == 0x3a ||   /* medium not present */
+                        sshdr.asc == 0x20))    /* invalid command */
                                /* this is no error here */
                                return 0;