]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ramoops: fix use of rounddown_pow_of_two()
authorMarco Stornelli <marco.stornelli@gmail.com>
Fri, 16 Dec 2011 04:50:51 +0000 (15:50 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 20 Dec 2011 07:44:11 +0000 (18:44 +1100)
The return value of rounddown_pow_of_two wasn't evaluated, so the
operation was a no-op.

Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/char/ramoops.c

index feda90cdac9f2b265d217cb78a1b7850d235ca5d..9c152ab2bfa77d879ffe9953fcc04f40b9b2622d 100644 (file)
@@ -125,8 +125,8 @@ static int __init ramoops_probe(struct platform_device *pdev)
                goto fail3;
        }
 
-       rounddown_pow_of_two(pdata->mem_size);
-       rounddown_pow_of_two(pdata->record_size);
+       pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
+       pdata->record_size = rounddown_pow_of_two(pdata->record_size);
 
        /* Check for the minimum memory size */
        if (pdata->mem_size < MIN_MEM_SIZE &&