]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ppp: slight optimization of addr compare
authordingtianhong <dingtianhong@huawei.com>
Thu, 26 Dec 2013 11:40:35 +0000 (19:40 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Dec 2013 18:31:33 +0000 (13:31 -0500)
Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Michal Ostrowski <mostrows@earthlink.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp/pppoe.c

index 82ee6ed954cb84272aa41be0fa3ad12eb6c64e2c..2ea7efd118577169f52c8b353148e53a8a00b8b1 100644 (file)
@@ -131,12 +131,12 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
 
 static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
 {
-       return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
+       return a->sid == b->sid && ether_addr_equal(a->remote, b->remote);
 }
 
 static inline int cmp_addr(struct pppoe_addr *a, __be16 sid, char *addr)
 {
-       return a->sid == sid && !memcmp(a->remote, addr, ETH_ALEN);
+       return a->sid == sid && ether_addr_equal(a->remote, addr);
 }
 
 #if 8 % PPPOE_HASH_BITS