]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
Staging: ion: fix code style warning from NULL comparisons
authorQuytelda Kahja <quytelda@tamalin.org>
Tue, 27 Jun 2017 21:35:46 +0000 (14:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Jun 2017 14:38:53 +0000 (16:38 +0200)
This patch replaces several instances where a pointer is compared to NULL
(i.e., `ptr == NULL`) with `!ptr`, which is preferred.

Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ion/ion.c

index 43ecb4af1b41d1e56df6f6f92b696f613acd4376..93e2c90fa77d51f42ed0e945907c05302bf00c45 100644 (file)
@@ -103,7 +103,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
                        goto err2;
        }
 
-       if (buffer->sg_table == NULL) {
+       if (!buffer->sg_table) {
                WARN_ONCE(1, "This heap needs to set the sgtable");
                ret = -EINVAL;
                goto err1;
@@ -161,7 +161,7 @@ static void *ion_buffer_kmap_get(struct ion_buffer *buffer)
                return buffer->vaddr;
        }
        vaddr = buffer->heap->ops->map_kernel(buffer->heap, buffer);
-       if (WARN_ONCE(vaddr == NULL,
+       if (WARN_ONCE(!vaddr,
                      "heap->ops->map_kernel should return ERR_PTR on error"))
                return ERR_PTR(-EINVAL);
        if (IS_ERR(vaddr))
@@ -425,7 +425,7 @@ int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned int flags)
        }
        up_read(&dev->lock);
 
-       if (buffer == NULL)
+       if (!buffer)
                return -ENODEV;
 
        if (IS_ERR(buffer))