]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
pinctrl: ns2: remove redundant dev_err call in ns2_pinmux_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 12 Jul 2016 14:19:45 +0000 (14:19 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 22 Jul 2016 14:37:25 +0000 (16:37 +0200)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-ns2-mux.c

index 7e5f7b7bf4d55bb844331e60ff967d1b7d2fad23..ca817896ed241e3909c2aad8b77f2a23fb29913a 100644 (file)
@@ -1044,10 +1044,8 @@ static int ns2_pinmux_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        pinctrl->base0 = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(pinctrl->base0)) {
-               dev_err(&pdev->dev, "unable to map I/O space\n");
+       if (IS_ERR(pinctrl->base0))
                return PTR_ERR(pinctrl->base0);
-       }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
        pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start,
@@ -1059,10 +1057,8 @@ static int ns2_pinmux_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
        pinctrl->pinconf_base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(pinctrl->pinconf_base)) {
-               dev_err(&pdev->dev, "unable to map I/O space\n");
+       if (IS_ERR(pinctrl->pinconf_base))
                return PTR_ERR(pinctrl->pinconf_base);
-       }
 
        ret = ns2_mux_log_init(pinctrl);
        if (ret) {