]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
hwmon: (adt7462) ADT7462_REG_VOLT_MAX() should return 0
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 14 Aug 2013 09:45:26 +0000 (12:45 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 27 Aug 2013 15:28:01 +0000 (08:28 -0700)
The callers never check for negative but they sometimes check for zero
returns:

int reg = ADT7462_REG_VOLT_MAX(data, i);
        data->volt_max[i] =
(reg ? i2c_smbus_read_byte_data(client, reg) : 0);

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/adt7462.c

index 69481d3a3d231fec48e1f43f0489e20879613daf..3e6aba12e46a715ed46f63382993b586f60881d0 100644 (file)
@@ -333,7 +333,7 @@ static int ADT7462_REG_VOLT_MAX(struct adt7462_data *data, int which)
                        return 0x4C;
                break;
        }
-       return -ENODEV;
+       return 0;
 }
 
 static int ADT7462_REG_VOLT_MIN(struct adt7462_data *data, int which)
@@ -392,7 +392,7 @@ static int ADT7462_REG_VOLT_MIN(struct adt7462_data *data, int which)
                        return 0x77;
                break;
        }
-       return -ENODEV;
+       return 0;
 }
 
 static int ADT7462_REG_VOLT(struct adt7462_data *data, int which)