]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
rtc: rtc-vt8500: use devm_rtc_device_register()
authorJingoo Han <jg1.han@samsung.com>
Wed, 20 Mar 2013 04:08:09 +0000 (15:08 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 21 Mar 2013 05:34:16 +0000 (16:34 +1100)
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-vt8500.c

index a000bc0a8bffdbf3bc8e61a05ebd2ec44c340eaa..d89efee6d29e051d89761c33205434aa39a1e90e 100644 (file)
@@ -252,7 +252,7 @@ static int vt8500_rtc_probe(struct platform_device *pdev)
        writel(VT8500_RTC_CR_ENABLE,
               vt8500_rtc->regbase + VT8500_RTC_CR);
 
-       vt8500_rtc->rtc = rtc_device_register("vt8500-rtc", &pdev->dev,
+       vt8500_rtc->rtc = devm_rtc_device_register(&pdev->dev, "vt8500-rtc",
                                              &vt8500_rtc_ops, THIS_MODULE);
        if (IS_ERR(vt8500_rtc->rtc)) {
                ret = PTR_ERR(vt8500_rtc->rtc);
@@ -266,13 +266,11 @@ static int vt8500_rtc_probe(struct platform_device *pdev)
        if (ret < 0) {
                dev_err(&pdev->dev, "can't get irq %i, err %d\n",
                        vt8500_rtc->irq_alarm, ret);
-               goto err_unreg;
+               goto err_return;
        }
 
        return 0;
 
-err_unreg:
-       rtc_device_unregister(vt8500_rtc->rtc);
 err_return:
        return ret;
 }
@@ -281,8 +279,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
 {
        struct vt8500_rtc *vt8500_rtc = platform_get_drvdata(pdev);
 
-       rtc_device_unregister(vt8500_rtc->rtc);
-
        /* Disable alarm matching */
        writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);