]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
video: fbdev: pmagb-b-fb: remove incorrect __exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 20 Mar 2017 17:31:00 +0000 (18:31 +0100)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Mon, 20 Mar 2017 17:31:00 +0000 (18:31 +0100)
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/pmagb-b-fb.c

index a7a179a0bb33f2d85beb0301945375dad45e8f79..46e96c4515060f0c58ade6ff892f711ad39aa0a6 100644 (file)
@@ -353,7 +353,7 @@ err_alloc:
        return err;
 }
 
-static int __exit pmagbbfb_remove(struct device *dev)
+static int pmagbbfb_remove(struct device *dev)
 {
        struct tc_dev *tdev = to_tc_dev(dev);
        struct fb_info *info = dev_get_drvdata(dev);
@@ -388,7 +388,7 @@ static struct tc_driver pmagbbfb_driver = {
                .name   = "pmagbbfb",
                .bus    = &tc_bus_type,
                .probe  = pmagbbfb_probe,
-               .remove = __exit_p(pmagbbfb_remove),
+               .remove = pmagbbfb_remove,
        },
 };