]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ath10k: fix debugfs pktlog_filter write
authorAnilkumar Kolli <akolli@qti.qualcomm.com>
Fri, 11 Mar 2016 06:16:39 +0000 (11:46 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jun 2016 01:14:33 +0000 (18:14 -0700)
commit 9ddc486aa09a3413a6c492fcf160ce61bfccb7b1 upstream.

It is observed that, we are disabling the packet log if we write same
value to the pktlog_filter for the second time. Always enable pktlogs
on non zero filter.

Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter")
Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/ath/ath10k/debug.c

index 6cc1aa3449c88640359ef716e3b300b692154d24..1a88a24ffeacb9640329faf63b0798fc22683fde 100644 (file)
@@ -1986,7 +1986,12 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file,
                goto out;
        }
 
-       if (filter && (filter != ar->debug.pktlog_filter)) {
+       if (filter == ar->debug.pktlog_filter) {
+               ret = count;
+               goto out;
+       }
+
+       if (filter) {
                ret = ath10k_wmi_pdev_pktlog_enable(ar, filter);
                if (ret) {
                        ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n",