]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
spi: loopback-test: correct mismatched test description and configuration
authorAkinobu Mita <akinobu.mita@gmail.com>
Fri, 17 Mar 2017 18:17:26 +0000 (03:17 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 17 Mar 2017 21:53:53 +0000 (21:53 +0000)
The test "two tx-transfers - alter first" actually alters the second
not the first transfer.  Similarly the test "two tx-transfers - alter
second" actually alters the first not the second transfer.

The mismatches for the two symmetrical tests cancel each other's
mistakes.  But it's better to fix the mismatches to avoid confusion.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-loopback-test.c

index 50e620f4e8fe2ae29c655358e38d771c464ec01d..99422f3a15e07ddaa4e40b85a74ee1d781324b50 100644 (file)
@@ -132,7 +132,7 @@ static struct spi_test spi_tests[] = {
                .fill_option    = FILL_COUNT_8,
                .iterate_len    = { ITERATE_MAX_LEN },
                .iterate_tx_align = ITERATE_ALIGN,
-               .iterate_transfer_mask = BIT(1),
+               .iterate_transfer_mask = BIT(0),
                .transfers              = {
                        {
                                .len = 1,
@@ -149,7 +149,7 @@ static struct spi_test spi_tests[] = {
                .fill_option    = FILL_COUNT_8,
                .iterate_len    = { ITERATE_MAX_LEN },
                .iterate_tx_align = ITERATE_ALIGN,
-               .iterate_transfer_mask = BIT(0),
+               .iterate_transfer_mask = BIT(1),
                .transfers              = {
                        {
                                .len = 16,