]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
IB/mlx5: Fix passing casted pointer in mlx5_query_port_roce
authorLeon Romanovsky <leon@leon.nu>
Sat, 9 Jan 2016 11:06:25 +0000 (13:06 +0200)
committerDoug Ledford <dledford@redhat.com>
Tue, 19 Jan 2016 20:25:45 +0000 (15:25 -0500)
Fix static checker warning:
        drivers/infiniband/hw/mlx5/main.c:149 mlx5_query_port_roce()
        warn: passing casted pointer '&props->qkey_viol_cntr' to
'mlx5_query_nic_vport_qkey_viol_cntr()' 32 vs 16.

Fixes: 3f89a643eb29 ("IB/mlx5: Extend query_device/port to support RoCE")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mlx5/main.c

index 5dffb9e6abece6a3bb67134cdb954b39005859f1..f509dcb856655d5f68dd6a83fe394d53df4baf3a 100644 (file)
@@ -132,6 +132,7 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num,
        struct mlx5_ib_dev *dev = to_mdev(device);
        struct net_device *ndev;
        enum ib_mtu ndev_ib_mtu;
+       u16 qkey_viol_cntr;
 
        memset(props, 0, sizeof(*props));
 
@@ -146,8 +147,8 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num,
        props->state            = IB_PORT_DOWN;
        props->phys_state       = 3;
 
-       mlx5_query_nic_vport_qkey_viol_cntr(dev->mdev,
-                                           (u16 *)&props->qkey_viol_cntr);
+       mlx5_query_nic_vport_qkey_viol_cntr(dev->mdev, &qkey_viol_cntr);
+       props->qkey_viol_cntr = qkey_viol_cntr;
 
        ndev = mlx5_ib_get_netdev(device, port_num);
        if (!ndev)