]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[PATCH] IrDA: Incorrect TTP header reservation
authorJeet Chaudhuri <jeetlinux@yahoo.co.in>
Thu, 7 Dec 2006 23:32:22 +0000 (01:32 +0200)
committerChris Wright <chrisw@sous-sol.org>
Mon, 11 Dec 2006 19:32:39 +0000 (11:32 -0800)
We must reserve SAR + MAX_HEADER bytes for IrLMP to fit in.
This fixes an oops reported (and fixed) by Jeet Chaudhuri, when max_sdu_size
is greater than 0.

Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
net/irda/irttp.c

index 3c2e70b77df16375952f1c0bc889f298a588e8a9..da73e63ba5a685b217e2b72ccd5cbce3c23d20be 100644 (file)
@@ -1099,7 +1099,7 @@ int irttp_connect_request(struct tsap_cb *self, __u8 dtsap_sel,
                        return -ENOMEM;
 
                /* Reserve space for MUX_CONTROL and LAP header */
-               skb_reserve(tx_skb, TTP_MAX_HEADER);
+               skb_reserve(tx_skb, TTP_MAX_HEADER + TTP_SAR_HEADER);
        } else {
                tx_skb = userdata;
                /*
@@ -1348,7 +1348,7 @@ int irttp_connect_response(struct tsap_cb *self, __u32 max_sdu_size,
                        return -ENOMEM;
 
                /* Reserve space for MUX_CONTROL and LAP header */
-               skb_reserve(tx_skb, TTP_MAX_HEADER);
+               skb_reserve(tx_skb, TTP_MAX_HEADER + TTP_SAR_HEADER);
        } else {
                tx_skb = userdata;
                /*