]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net/can: can_dropped_invalid_skb can be boolean
authorYaowei Bai <bywxiaobai@163.com>
Thu, 8 Oct 2015 13:28:57 +0000 (21:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Oct 2015 14:49:01 +0000 (07:49 -0700)
This patch makes can_dropped_invalid_skb return bool due to this
particular function only using either one or zero as its return
value.

No functional change.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/can/dev.h

index 56dcadd837162804c7a6ab3cbeb1a80d0fffb565..735f9f8c4e43e5350f36bc4b39e9f8634778fd40 100644 (file)
@@ -78,7 +78,7 @@ struct can_priv {
 #define get_canfd_dlc(i)       (min_t(__u8, (i), CANFD_MAX_DLC))
 
 /* Drop a given socketbuffer if it does not contain a valid CAN frame. */
-static inline int can_dropped_invalid_skb(struct net_device *dev,
+static inline bool can_dropped_invalid_skb(struct net_device *dev,
                                          struct sk_buff *skb)
 {
        const struct canfd_frame *cfd = (struct canfd_frame *)skb->data;
@@ -94,12 +94,12 @@ static inline int can_dropped_invalid_skb(struct net_device *dev,
        } else
                goto inval_skb;
 
-       return 0;
+       return false;
 
 inval_skb:
        kfree_skb(skb);
        dev->stats.tx_dropped++;
-       return 1;
+       return true;
 }
 
 static inline bool can_is_canfd_skb(const struct sk_buff *skb)