]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 8 Feb 2017 16:23:10 +0000 (16:23 +0000)
committerBrian Norris <computersforpeace@gmail.com>
Fri, 10 Feb 2017 19:20:22 +0000 (11:20 -0800)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/spi-nor/aspeed-smc.c

index 7c86099450bedb65412702efef07abb28c05cda0..56051d30f0008172a099d08f8f56d667a66bc0a7 100644 (file)
@@ -723,17 +723,13 @@ static int aspeed_smc_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        controller->regs = devm_ioremap_resource(dev, res);
-       if (IS_ERR(controller->regs)) {
-               dev_err(dev, "Cannot remap controller address.\n");
+       if (IS_ERR(controller->regs))
                return PTR_ERR(controller->regs);
-       }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
        controller->ahb_base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(controller->ahb_base)) {
-               dev_err(dev, "Cannot remap controller address.\n");
+       if (IS_ERR(controller->ahb_base))
                return PTR_ERR(controller->ahb_base);
-       }
 
        ret = aspeed_smc_setup_flash(controller, np, res);
        if (ret)