]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
remoteproc: qcom-tz: Finish shutdown on timeout
authorBjorn Andersson <bjorn.andersson@sonymobile.com>
Wed, 10 Dec 2014 19:42:18 +0000 (11:42 -0800)
committerSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Mon, 11 Jan 2016 09:55:08 +0000 (09:55 +0000)
When the remote processor have hit an fatal error, it will not perform
the stop-ack handshake. So we have to finish the shutdown process to not
leave the remote processor in a dangling state (stopping us from
bringing it up again).

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
drivers/remoteproc/qcom_tz_pil.c

index 0b163ebde737810e35736d55cb1dac35f7ff3983..ee3821847910d0c98b935bcc6436c642598ecac8 100644 (file)
@@ -440,10 +440,8 @@ static int qproc_stop(struct rproc *rproc)
        gpiod_set_value(qproc->stop_gpio, 1);
 
        ret = wait_for_completion_timeout(&qproc->stop_done, msecs_to_jiffies(1000));
-       if (ret == 0) {
+       if (ret == 0)
                dev_err(qproc->dev, "timed out on wait\n");
-               return ret;
-       }
 
        gpiod_set_value(qproc->stop_gpio, 0);