]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
pinctrl: ingenic: checking for NULL instead of IS_ERR()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 14 Jun 2017 09:12:09 +0000 (12:12 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 20 Jun 2017 09:36:17 +0000 (11:36 +0200)
devm_pinctrl_register() returns error pointers, it doesn't return NULL.

Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-ingenic.c

index d8473d929cb14b2d96f2987633ad10d69d85ad7c..d8e8842967d651b383f7b46e7495861d19df211e 100644 (file)
@@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev)
        }
 
        jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc);
-       if (!jzpc->pctl) {
+       if (IS_ERR(jzpc->pctl)) {
                dev_err(dev, "Failed to register pinctrl\n");
-               return -EINVAL;
+               return PTR_ERR(jzpc->pctl);
        }
 
        for (i = 0; i < chip_info->num_groups; i++) {