- ENODEV is more appropriate than EINVAL if platform_get_resource() fails
- promote the return value from platform_get_irq() rather than inventing
a new one
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!mem) {
dev_err(dev, "no mmio space\n");
- return -EINVAL;
+ return -ENODEV;
}
irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
+ if (irq < 0) {
dev_err(dev, "no irq\n");
- return -EINVAL;
+ return irq;
}
if (pdata && pdata->ata_port_info)