]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ALSA: hda - Fix unbalance of i915 module refcount
authorTakashi Iwai <tiwai@suse.de>
Tue, 4 Jul 2017 14:04:38 +0000 (16:04 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 4 Jul 2017 14:04:38 +0000 (16:04 +0200)
The commit dba9b7b6ca1a ("ALSA: hda - Fix doubly initialization of
i915 component") contained a typo that leads to the unbalance of i915
module reference.  The value to be checked is not chip->driver_type
but chip->driver_caps.

Fixes: dba9b7b6ca1a ("ALSA: hda - Fix doubly initialization of i915 component")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196219
Reported-by: Martin Peres <martin.peres@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c

index 03e34edc8f246b80444cdabd166a3383051b275e..5ae8ddab641220f2ebb0a1e85438302e50d2b861 100644 (file)
@@ -1385,7 +1385,7 @@ static int azx_free(struct azx *chip)
                if (hda->need_i915_power)
                        snd_hdac_display_power(bus, false);
        }
-       if (chip->driver_type & AZX_DCAPS_I915_COMPONENT)
+       if (chip->driver_caps & AZX_DCAPS_I915_COMPONENT)
                snd_hdac_i915_exit(bus);
        kfree(hda);