]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
kconfig/lxdialog: Use new mininimum resize definitions in conf_choice()
authorSedat Dilek <sedat.dilek@gmail.com>
Sun, 16 Jun 2013 16:43:04 +0000 (18:43 +0200)
committerYann E. MORIN <yann.morin.1998@free.fr>
Tue, 18 Jun 2013 21:58:57 +0000 (23:58 +0200)
This is a cleanup which uses the proper (new) definitions and does
not change current behaviour.

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
Yann had some more ideas on improvements:

"What would be nice is an improvement that scales the choice window to
the number of entries in the choice. If there are a lot of choice
entries, then the choice popup grows in height (but does not overflow
the screen of course). So, instead of seeing only 6 entries, we'd see
as much as possible in the current screen.

Ditto for the width: the popup adapts to the longest prompt (but does
not overflow the screen either, of course), so prompts are not
truncated."

NOTE: This patch requires [1].

[1] http://marc.info/?l=linux-kbuild&m=137128726917166&w=2

scripts/kconfig/mconf.c

index 387dc8daf7b2d43ff96b735f6bd60b4c650f85a8..2396c5be31adf45889a97b549a4dc617193bfbaf 100644 (file)
@@ -825,7 +825,9 @@ static void conf_choice(struct menu *menu)
                dialog_clear();
                res = dialog_checklist(prompt ? _(prompt) : _("Main Menu"),
                                        _(radiolist_instructions),
-                                        15, 70, 6);
+                                       MENUBOX_HEIGTH_MIN,
+                                       MENUBOX_WIDTH_MIN,
+                                       CHECKLIST_HEIGTH_MIN);
                selected = item_activate_selected();
                switch (res) {
                case 0: