]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
USB: ehci-ppc-of: problems in unwind
authorDan Carpenter <error27@gmail.com>
Sat, 14 Aug 2010 09:06:19 +0000 (11:06 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 4 Sep 2010 00:33:40 +0000 (17:33 -0700)
commit08a3b3b1c2e622e378d9086aee9e2e42ce37591d
treefe52d1eba9ec20201de1ea723e51628eb9522894
parent0f1312b260499b34bb92fc9bd8ca1560dda2c4da
USB: ehci-ppc-of: problems in unwind

The iounmap(ehci->ohci_hcctrl_reg); should be the first thing we do
because the ioremap() was the last thing we did.  Also if we hit any of
the goto statements in the original code then it would have led to a
NULL dereference of "ehci".  This bug was introduced in: 796bcae7361c
"USB: powerpc: Workaround for the PPC440EPX USBH_23 errata [take 3]"

I modified the few lines in front a little so that my code didn't
obscure the return success code path.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci-ppc-of.c