]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
cgroup: fix an off-by-one bug which may trigger BUG_ON()
authorLi Zefan <lizefan@huawei.com>
Tue, 12 Mar 2013 22:36:00 +0000 (15:36 -0700)
committerTejun Heo <tj@kernel.org>
Wed, 20 Mar 2013 14:50:04 +0000 (07:50 -0700)
commit3ac1707a13a3da9cfc8f242a15b2fae6df2c5f88
tree2697a8fe41fcd9e5b31f5c3582fbfb2cdbdd58bf
parent80f36c2a1a612ca419e5b864a7e4808e797d9feb
cgroup: fix an off-by-one bug which may trigger BUG_ON()

The 3rd parameter of flex_array_prealloc() is the number of elements,
not the index of the last element.

The effect of the bug is, when opening cgroup.procs, a flex array will
be allocated and all elements of the array is allocated with
GFP_KERNEL flag, but the last one is GFP_ATOMIC, and if we fail to
allocate memory for it, it'll trigger a BUG_ON().

Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
kernel/cgroup.c