]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
RDMA/uverbs: Check port number supplied by user verbs cmds
authorBoris Pismenny <borisp@mellanox.com>
Tue, 27 Jun 2017 12:09:13 +0000 (15:09 +0300)
committerDoug Ledford <dledford@redhat.com>
Mon, 3 Jul 2017 15:06:55 +0000 (11:06 -0400)
commit5ecce4c9b17bed4dc9cb58bfb10447307569b77b
tree8a3e4ec35c1a0c86a405089cf79a289057f166ce
parenta379d69f00f28063a7a1c3de235e2996c2c5a6f5
RDMA/uverbs: Check port number supplied by user verbs cmds

The ib_uverbs_create_ah() ind ib_uverbs_modify_qp() calls receive
the port number from user input as part of its attributes and assumes
it is valid. Down on the stack, that parameter is used to access kernel
data structures.  If the value is invalid, the kernel accesses memory
it should not.  To prevent this, verify the port number before using it.

BUG: KASAN: use-after-free in ib_uverbs_create_ah+0x6d5/0x7b0
Read of size 4 at addr ffff880018d67ab8 by task syz-executor/313

BUG: KASAN: slab-out-of-bounds in modify_qp.isra.4+0x19d0/0x1ef0
Read of size 4 at addr ffff88006c40ec58 by task syz-executor/819

Fixes: 67cdb40ca444 ("[IB] uverbs: Implement more commands")
Fixes: 189aba99e70 ("IB/uverbs: Extend modify_qp and support packet pacing")
Cc: <stable@vger.kernel.org> # v2.6.14+
Cc: <security@kernel.org>
Cc: Yevgeny Kliteynik <kliteyn@mellanox.com>
Cc: Tziporet Koren <tziporet@mellanox.com>
Cc: Alex Polak <alexpo@mellanox.com>
Signed-off-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/uverbs_cmd.c