]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
MIPS: Avoid using unwind_stack() with usermode
authorJames Hogan <james.hogan@imgtec.com>
Fri, 4 Dec 2015 22:25:02 +0000 (22:25 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 9 May 2016 10:00:02 +0000 (12:00 +0200)
commit81a76d7119f63c359750e4adeff922a31ad1135f
tree993648441e7bb84b8565fe326e675edbe176d3dc
parenta816b306c62195b7c43c92cb13330821a96bdc27
MIPS: Avoid using unwind_stack() with usermode

When showing backtraces in response to traps, for example crashes and
address errors (usually unaligned accesses) when they are set in debugfs
to be reported, unwind_stack will be used if the PC was in the kernel
text address range. However since EVA it is possible for user and kernel
address ranges to overlap, and even without EVA userland can still
trigger an address error by jumping to a KSeg0 address.

Adjust the check to also ensure that it was running in kernel mode. I
don't believe any harm can come of this problem, since unwind_stack() is
sufficiently defensive, however it is only meant for unwinding kernel
code, so to be correct it should use the raw backtracing instead.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Reviewed-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: <stable@vger.kernel.org> # 3.15+
Patchwork: https://patchwork.linux-mips.org/patch/11701/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
(cherry picked from commit d2941a975ac745c607dfb590e92bb30bc352dad9)
arch/mips/kernel/traps.c