]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
quota: Don't write quota info in dquot_commit()
authorJan Kara <jack@suse.cz>
Thu, 31 Mar 2011 16:36:52 +0000 (18:36 +0200)
committerJan Kara <jack@suse.cz>
Thu, 31 Mar 2011 22:23:46 +0000 (00:23 +0200)
commitb03f24567ce7caf2420b8be4c6eb74c191d59a91
treef0337cbc006ff57bdaed3d48d60d0054d23afb74
parent523334ba508a8baaf5fc9f15fbad9ed04f334f48
quota: Don't write quota info in dquot_commit()

There's no reason to write quota info in dquot_commit(). The writing is a
relict from the old days when we didn't have dquot_acquire() and
dquot_release() and thus dquot_commit() could have created / removed quota
structures from the file. These days dquot_commit() only updates usage counters
/ limits in quota structure and thus there's no need to write quota info.

This also fixes an issue with journaling filesystem which didn't reserve
enough space in the transaction for write of quota info (it could have been
dirty at the time of dquot_commit() because of a race with other operation
changing it).

CC: stable@kernel.org
Reported-and-tested-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/quota/dquot.c