]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
bpf: avoid copying junk bytes in bpf_get_current_comm()
authorAlexei Starovoitov <ast@fb.com>
Thu, 10 Mar 2016 04:02:33 +0000 (20:02 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Mar 2016 04:27:30 +0000 (23:27 -0500)
commitcdc4e47da8f4c32eeb6b2061a8a834f4362a12b7
treed66e39c8dccee7e5cf1662305a102c6235d315be
parentb8cdc05173f05d212627b7aba7ec47fa334a79f2
bpf: avoid copying junk bytes in bpf_get_current_comm()

Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but
the result is typically passed to print("%s", buf) and extra bytes
after zero don't cause any harm.
In bpf the result of bpf_get_current_comm() is used as the part of
map key and was causing spurious hash map mismatches.
Use strlcpy() to guarantee zero-terminated string.
bpf verifier checks that output buffer is zero-initialized,
so even for short task names the output buffer don't have junk bytes.
Note it's not a security concern, since kprobe+bpf is root only.

Fixes: ffeedafbf023 ("bpf: introduce current->pid, tgid, uid, gid, comm accessors")
Reported-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
kernel/bpf/helpers.c