]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue
authorMing Lei <ming.lei@redhat.com>
Sun, 18 Jun 2017 20:24:27 +0000 (14:24 -0600)
committerJens Axboe <axboe@kernel.dk>
Sun, 18 Jun 2017 20:24:27 +0000 (14:24 -0600)
commitf4560ffe8cec1361b1021d81aca6a4173f8e7c87
tree957cae770ed234d2e03fef8a6e458296f011369e
parentf660174e8bcdb2bf99129f9f7c86e5fc0e830f85
blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue

It is required that no dispatch can happen any more once
blk_mq_quiesce_queue() returns, and we don't have such requirement
on APIs of stopping queue.

But blk_mq_quiesce_queue() still may not block/drain dispatch in the
the case of BLK_MQ_S_START_ON_RUN, so use the new introduced flag of
QUEUE_FLAG_QUIESCED and evaluate it inside RCU read-side critical
sections for fixing this issue.

Also blk_mq_quiesce_queue() is implemented via stopping queue, which
limits its uses, and easy to cause race, because any queue restart in
other paths may break blk_mq_quiesce_queue(). With the introduced
flag of QUEUE_FLAG_QUIESCED, we don't need to depend on stopping queue
for quiescing any more.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-sched.c
block/blk-mq.c
include/linux/blk-mq.h
include/linux/blkdev.h