]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
p54: fix tx feedback status flag check
authorChristian Lamparter <chunkeey@googlemail.com>
Tue, 24 Aug 2010 20:54:05 +0000 (22:54 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 30 Aug 2010 20:02:32 +0000 (16:02 -0400)
commitf880c2050f30b23c9b6f80028c09f76e693bf309
tree69039659a83d3d47a46cf3bc081f6cfdf5441d35
parentd8e1ba76d619dbc0be8fbeee4e6c683b5c812d3a
p54: fix tx feedback status flag check

Michael reported that p54* never really entered power
save mode, even tough it was enabled.

It turned out that upon a power save mode change the
firmware will set a special flag onto the last outgoing
frame tx status (which in this case is almost always the
designated PSM nullfunc frame). This flag confused the
driver; It erroneously reported transmission failures
to the stack, which then generated the next nullfunc.
and so on...

Cc: <stable@kernel.org>
Reported-by: Michael Buesch <mb@bu3sch.de>
Tested-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54/txrx.c