]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
rtc: max77686: Properly handle regmap_irq_get_virq() error code
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Thu, 4 Feb 2016 00:26:35 +0000 (09:26 +0900)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 4 Feb 2016 22:44:14 +0000 (23:44 +0100)
commitfb166ba1d7f0a662f7332f4ff660a0d6f4d76915
tree3d559251aec9b2bc37e4c63095803cd7b542821c
parent1e5813bded3c6702841549ac2533680f410aea43
rtc: max77686: Properly handle regmap_irq_get_virq() error code

The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
but driver checked only for value of 0.

This could lead to a cast of -EINVAL to an unsigned int used as a
interrupt number for devm_request_threaded_irq(). Although this is not
yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
might be a misleading when diagnosing errors.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq")
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-max77686.c