]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - fs/jffs2/jffs2_1pass.c
JFFS2: Improve speed reading flash files
[karo-tx-uboot.git] / fs / jffs2 / jffs2_1pass.c
index d1423c1cdae973b48055c71bbe4dcfcdf14cf293..e58e7d25cff128b248db26b99b0f50a73428a9bf 100644 (file)
@@ -92,7 +92,7 @@
  * - implemented fragment sorting to ensure that the newest data is copied
  *   if there are multiple copies of fragments for a certain file offset.
  *
- * The fragment sorting feature must be enabled by CFG_JFFS2_SORT_FRAGMENTS.
+ * The fragment sorting feature must be enabled by CONFIG_SYS_JFFS2_SORT_FRAGMENTS.
  * Sorting is done while adding fragments to the lists, which is more or less a
  * bubble sort. This takes a lot of time, and is most probably not an issue if
  * the boot filesystem is always mounted readonly.
 #include <common.h>
 #include <config.h>
 #include <malloc.h>
+#include <div64.h>
 #include <linux/stat.h>
 #include <linux/time.h>
 #include <watchdog.h>
-
-#if defined(CONFIG_CMD_JFFS2)
-
 #include <jffs2/jffs2.h>
 #include <jffs2/jffs2_1pass.h>
+#include <linux/compat.h>
+#include <asm/errno.h>
 
 #include "jffs2_private.h"
 
 # define DEBUGF(fmt,args...)
 #endif
 
+#include "summary.h"
+
 /* keeps pointer to currentlu processed partition */
 static struct part_info *current_part;
 
 #if (defined(CONFIG_JFFS2_NAND) && \
      defined(CONFIG_CMD_NAND) )
-#if defined(CFG_NAND_LEGACY)
-#include <linux/mtd/nand_legacy.h>
-#else
 #include <nand.h>
-#endif
 /*
  * Support for jffs2 on top of NAND-flash
  *
@@ -161,12 +159,6 @@ static struct part_info *current_part;
  *
  */
 
-#if defined(CFG_NAND_LEGACY)
-/* this one defined in nand_legacy.c */
-int read_jffs2_nand(size_t start, size_t len,
-               size_t * retlen, u_char * buf, int nanddev);
-#endif
-
 #define NAND_PAGE_SIZE 512
 #define NAND_PAGE_SHIFT 9
 #define NAND_PAGE_MASK (~(NAND_PAGE_SIZE-1))
@@ -201,15 +193,6 @@ static int read_nand_cached(u32 off, u32 size, u_char *buf)
                                }
                        }
 
-#if defined(CFG_NAND_LEGACY)
-                       if (read_jffs2_nand(nand_cache_off, NAND_CACHE_SIZE,
-                                               &retlen, nand_cache, id->num) < 0 ||
-                                       retlen != NAND_CACHE_SIZE) {
-                               printf("read_nand_cached: error reading nand off %#x size %d bytes\n",
-                                               nand_cache_off, NAND_CACHE_SIZE);
-                               return -1;
-                       }
-#else
                        retlen = NAND_CACHE_SIZE;
                        if (nand_read(&nand_info[id->num], nand_cache_off,
                                                &retlen, nand_cache) != 0 ||
@@ -218,7 +201,6 @@ static int read_nand_cached(u32 off, u32 size, u_char *buf)
                                                nand_cache_off, NAND_CACHE_SIZE);
                                return -1;
                        }
-#endif
                }
                cpy_bytes = nand_cache_off + NAND_CACHE_SIZE - (off + bytes_read);
                if (cpy_bytes > size - bytes_read)
@@ -248,7 +230,7 @@ static void *get_fl_mem_nand(u32 off, u32 size, void *ext_buf)
        return buf;
 }
 
-static void *get_node_mem_nand(u32 off)
+static void *get_node_mem_nand(u32 off, void *ext_buf)
 {
        struct jffs2_unknown_node node;
        void *ret = NULL;
@@ -258,7 +240,7 @@ static void *get_node_mem_nand(u32 off)
 
        if (!(ret = get_fl_mem_nand(off, node.magic ==
                               JFFS2_MAGIC_BITMASK ? node.totlen : sizeof(node),
-                              NULL))) {
+                              ext_buf))) {
                printf("off = %#x magic %#x type %#x node.totlen = %d\n",
                       off, node.magic, node.nodetype, node.totlen);
        }
@@ -271,6 +253,107 @@ static void put_fl_mem_nand(void *buf)
 }
 #endif
 
+#if defined(CONFIG_CMD_ONENAND)
+
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/onenand.h>
+#include <onenand_uboot.h>
+
+#define ONENAND_PAGE_SIZE 2048
+#define ONENAND_PAGE_SHIFT 11
+#define ONENAND_PAGE_MASK (~(ONENAND_PAGE_SIZE-1))
+
+#ifndef ONENAND_CACHE_PAGES
+#define ONENAND_CACHE_PAGES 4
+#endif
+#define ONENAND_CACHE_SIZE (ONENAND_CACHE_PAGES*ONENAND_PAGE_SIZE)
+
+static u8* onenand_cache;
+static u32 onenand_cache_off = (u32)-1;
+
+static int read_onenand_cached(u32 off, u32 size, u_char *buf)
+{
+       u32 bytes_read = 0;
+       size_t retlen;
+       int cpy_bytes;
+
+       while (bytes_read < size) {
+               if ((off + bytes_read < onenand_cache_off) ||
+                   (off + bytes_read >= onenand_cache_off + ONENAND_CACHE_SIZE)) {
+                       onenand_cache_off = (off + bytes_read) & ONENAND_PAGE_MASK;
+                       if (!onenand_cache) {
+                               /* This memory never gets freed but 'cause
+                                  it's a bootloader, nobody cares */
+                               onenand_cache = malloc(ONENAND_CACHE_SIZE);
+                               if (!onenand_cache) {
+                                       printf("read_onenand_cached: can't alloc cache size %d bytes\n",
+                                              ONENAND_CACHE_SIZE);
+                                       return -1;
+                               }
+                       }
+
+                       retlen = ONENAND_CACHE_SIZE;
+                       if (onenand_read(&onenand_mtd, onenand_cache_off, retlen,
+                                               &retlen, onenand_cache) != 0 ||
+                                       retlen != ONENAND_CACHE_SIZE) {
+                               printf("read_onenand_cached: error reading nand off %#x size %d bytes\n",
+                                       onenand_cache_off, ONENAND_CACHE_SIZE);
+                               return -1;
+                       }
+               }
+               cpy_bytes = onenand_cache_off + ONENAND_CACHE_SIZE - (off + bytes_read);
+               if (cpy_bytes > size - bytes_read)
+                       cpy_bytes = size - bytes_read;
+               memcpy(buf + bytes_read,
+                      onenand_cache + off + bytes_read - onenand_cache_off,
+                      cpy_bytes);
+               bytes_read += cpy_bytes;
+       }
+       return bytes_read;
+}
+
+static void *get_fl_mem_onenand(u32 off, u32 size, void *ext_buf)
+{
+       u_char *buf = ext_buf ? (u_char *)ext_buf : (u_char *)malloc(size);
+
+       if (NULL == buf) {
+               printf("get_fl_mem_onenand: can't alloc %d bytes\n", size);
+               return NULL;
+       }
+       if (read_onenand_cached(off, size, buf) < 0) {
+               if (!ext_buf)
+                       free(buf);
+               return NULL;
+       }
+
+       return buf;
+}
+
+static void *get_node_mem_onenand(u32 off, void *ext_buf)
+{
+       struct jffs2_unknown_node node;
+       void *ret = NULL;
+
+       if (NULL == get_fl_mem_onenand(off, sizeof(node), &node))
+               return NULL;
+
+       ret = get_fl_mem_onenand(off, node.magic ==
+                       JFFS2_MAGIC_BITMASK ? node.totlen : sizeof(node),
+                       ext_buf);
+       if (!ret) {
+               printf("off = %#x magic %#x type %#x node.totlen = %d\n",
+                      off, node.magic, node.nodetype, node.totlen);
+       }
+       return ret;
+}
+
+
+static void put_fl_mem_onenand(void *buf)
+{
+       free(buf);
+}
+#endif
+
 
 #if defined(CONFIG_CMD_FLASH)
 /*
@@ -279,7 +362,7 @@ static void put_fl_mem_nand(void *buf)
  * NOR flash memory is mapped in processor's address space,
  * just return address.
  */
-static inline void *get_fl_mem_nor(u32 off)
+static inline void *get_fl_mem_nor(u32 off, u32 size, void *ext_buf)
 {
        u32 addr = off;
        struct mtdids *id = current_part->dev->id;
@@ -288,12 +371,22 @@ static inline void *get_fl_mem_nor(u32 off)
        flash_info_t *flash = &flash_info[id->num];
 
        addr += flash->start[0];
+       if (ext_buf) {
+               memcpy(ext_buf, (void *)addr, size);
+               return ext_buf;
+       }
        return (void*)addr;
 }
 
-static inline void *get_node_mem_nor(u32 off)
+static inline void *get_node_mem_nor(u32 off, void *ext_buf)
 {
-       return (void*)get_fl_mem_nor(off);
+       struct jffs2_unknown_node *pNode;
+
+       /* pNode will point directly to flash - don't provide external buffer
+          and don't care about size */
+       pNode = get_fl_mem_nor(off, 0, NULL);
+       return (void *)get_fl_mem_nor(off, pNode->magic == JFFS2_MAGIC_BITMASK ?
+                       pNode->totlen : sizeof(*pNode), ext_buf);
 }
 #endif
 
@@ -306,48 +399,75 @@ static inline void *get_fl_mem(u32 off, u32 size, void *ext_buf)
 {
        struct mtdids *id = current_part->dev->id;
 
+       switch(id->type) {
 #if defined(CONFIG_CMD_FLASH)
-       if (id->type == MTD_DEV_TYPE_NOR)
-               return get_fl_mem_nor(off);
+       case MTD_DEV_TYPE_NOR:
+               return get_fl_mem_nor(off, size, ext_buf);
+               break;
 #endif
-
 #if defined(CONFIG_JFFS2_NAND) && defined(CONFIG_CMD_NAND)
-       if (id->type == MTD_DEV_TYPE_NAND)
+       case MTD_DEV_TYPE_NAND:
                return get_fl_mem_nand(off, size, ext_buf);
+               break;
 #endif
-
-       printf("get_fl_mem: unknown device type, using raw offset!\n");
+#if defined(CONFIG_CMD_ONENAND)
+       case MTD_DEV_TYPE_ONENAND:
+               return get_fl_mem_onenand(off, size, ext_buf);
+               break;
+#endif
+       default:
+               printf("get_fl_mem: unknown device type, " \
+                       "using raw offset!\n");
+       }
        return (void*)off;
 }
 
-static inline void *get_node_mem(u32 off)
+static inline void *get_node_mem(u32 off, void *ext_buf)
 {
        struct mtdids *id = current_part->dev->id;
 
+       switch(id->type) {
 #if defined(CONFIG_CMD_FLASH)
-       if (id->type == MTD_DEV_TYPE_NOR)
-               return get_node_mem_nor(off);
+       case MTD_DEV_TYPE_NOR:
+               return get_node_mem_nor(off, ext_buf);
+               break;
 #endif
-
 #if defined(CONFIG_JFFS2_NAND) && \
     defined(CONFIG_CMD_NAND)
-       if (id->type == MTD_DEV_TYPE_NAND)
-               return get_node_mem_nand(off);
+       case MTD_DEV_TYPE_NAND:
+               return get_node_mem_nand(off, ext_buf);
+               break;
 #endif
-
-       printf("get_node_mem: unknown device type, using raw offset!\n");
+#if defined(CONFIG_CMD_ONENAND)
+       case MTD_DEV_TYPE_ONENAND:
+               return get_node_mem_onenand(off, ext_buf);
+               break;
+#endif
+       default:
+               printf("get_fl_mem: unknown device type, " \
+                       "using raw offset!\n");
+       }
        return (void*)off;
 }
 
-static inline void put_fl_mem(void *buf)
+static inline void put_fl_mem(void *buf, void *ext_buf)
 {
-#if defined(CONFIG_JFFS2_NAND) && \
-    defined(CONFIG_CMD_NAND)
        struct mtdids *id = current_part->dev->id;
 
-       if (id->type == MTD_DEV_TYPE_NAND)
+       /* If buf is the same as ext_buf, it was provided by the caller -
+          we shouldn't free it then. */
+       if (buf == ext_buf)
+               return;
+       switch (id->type) {
+#if defined(CONFIG_JFFS2_NAND) && defined(CONFIG_CMD_NAND)
+       case MTD_DEV_TYPE_NAND:
                return put_fl_mem_nand(buf);
 #endif
+#if defined(CONFIG_CMD_ONENAND)
+       case MTD_DEV_TYPE_ONENAND:
+               return put_fl_mem_onenand(buf);
+#endif
+       }
 }
 
 /* Compression names */
@@ -359,15 +479,11 @@ static char *compr_names[] = {
        "COPY",
        "DYNRUBIN",
        "ZLIB",
-#if defined(CONFIG_JFFS2_LZO_LZARI)
+#if defined(CONFIG_JFFS2_LZO)
        "LZO",
-       "LZARI",
 #endif
 };
 
-/* Spinning wheel */
-static char spinner[] = { '|', '/', '-', '\\' };
-
 /* Memory management */
 struct mem_block {
        u32     index;
@@ -429,7 +545,7 @@ static struct b_node *
 insert_node(struct b_list *list, u32 offset)
 {
        struct b_node *new;
-#ifdef CFG_JFFS2_SORT_FRAGMENTS
+#ifdef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
        struct b_node *b, *prev;
 #endif
 
@@ -439,7 +555,7 @@ insert_node(struct b_list *list, u32 offset)
        }
        new->offset = offset;
 
-#ifdef CFG_JFFS2_SORT_FRAGMENTS
+#ifdef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
        if (list->listTail != NULL && list->listCompare(new, list->listTail))
                prev = list->listTail;
        else if (list->listLast != NULL && list->listCompare(new, list->listLast))
@@ -476,20 +592,24 @@ insert_node(struct b_list *list, u32 offset)
        return new;
 }
 
-#ifdef CFG_JFFS2_SORT_FRAGMENTS
+#ifdef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
 /* Sort data entries with the latest version last, so that if there
  * is overlapping data the latest version will be used.
  */
 static int compare_inodes(struct b_node *new, struct b_node *old)
 {
-       struct jffs2_raw_inode ojNew;
-       struct jffs2_raw_inode ojOld;
-       struct jffs2_raw_inode *jNew =
-               (struct jffs2_raw_inode *)get_fl_mem(new->offset, sizeof(ojNew), &ojNew);
-       struct jffs2_raw_inode *jOld =
-               (struct jffs2_raw_inode *)get_fl_mem(old->offset, sizeof(ojOld), &ojOld);
-
-       return jNew->version > jOld->version;
+       /*
+        * Only read in the version info from flash, not the entire inode.
+        * This can make a big difference to speed if flash is slow.
+        */
+       u32 new_version;
+       u32 old_version;
+       get_fl_mem(new->offset + offsetof(struct jffs2_raw_inode, version),
+                  sizeof(new_version), &new_version);
+       get_fl_mem(old->offset + offsetof(struct jffs2_raw_inode, version),
+                  sizeof(old_version), &old_version);
+
+       return new_version > old_version;
 }
 
 /* Sort directory entries so all entries in the same directory
@@ -499,62 +619,48 @@ static int compare_inodes(struct b_node *new, struct b_node *old)
  */
 static int compare_dirents(struct b_node *new, struct b_node *old)
 {
-       struct jffs2_raw_dirent ojNew;
-       struct jffs2_raw_dirent ojOld;
-       struct jffs2_raw_dirent *jNew =
-               (struct jffs2_raw_dirent *)get_fl_mem(new->offset, sizeof(ojNew), &ojNew);
-       struct jffs2_raw_dirent *jOld =
-               (struct jffs2_raw_dirent *)get_fl_mem(old->offset, sizeof(ojOld), &ojOld);
-       int cmp;
-
-       /* ascending sort by pino */
-       if (jNew->pino != jOld->pino)
-               return jNew->pino > jOld->pino;
-
-       /* pino is the same, so use ascending sort by nsize, so
-        * we don't do strncmp unless we really must.
-        */
-       if (jNew->nsize != jOld->nsize)
-               return jNew->nsize > jOld->nsize;
-
-       /* length is also the same, so use ascending sort by name
+       /*
+        * Using NULL as the buffer for NOR flash prevents the entire node
+        * being read. This makes most comparisons much quicker as only one
+        * or two entries from the node will be used most of the time.
         */
-       cmp = strncmp((char *)jNew->name, (char *)jOld->name, jNew->nsize);
-       if (cmp != 0)
-               return cmp > 0;
-
-       /* we have duplicate names in this directory, so use ascending
-        * sort by version
-        */
-       if (jNew->version > jOld->version) {
-               /* since jNew is newer, we know jOld is not valid, so
-                * mark it with inode 0 and it will not be used
+       struct jffs2_raw_dirent *jNew = get_node_mem(new->offset, NULL);
+       struct jffs2_raw_dirent *jOld = get_node_mem(old->offset, NULL);
+       int cmp;
+       int ret;
+
+       if (jNew->pino != jOld->pino) {
+               /* ascending sort by pino */
+               ret = jNew->pino > jOld->pino;
+       } else if (jNew->nsize != jOld->nsize) {
+               /*
+                * pino is the same, so use ascending sort by nsize,
+                * so we don't do strncmp unless we really must.
                 */
-               jOld->ino = 0;
-               return 1;
+               ret = jNew->nsize > jOld->nsize;
+       } else {
+               /*
+                * length is also the same, so use ascending sort by name
+                */
+               cmp = strncmp((char *)jNew->name, (char *)jOld->name,
+                       jNew->nsize);
+               if (cmp != 0) {
+                       ret = cmp > 0;
+               } else {
+                       /*
+                        * we have duplicate names in this directory,
+                        * so use ascending sort by version
+                        */
+                       ret = jNew->version > jOld->version;
+               }
        }
+       put_fl_mem(jNew, NULL);
+       put_fl_mem(jOld, NULL);
 
-       return 0;
+       return ret;
 }
 #endif
 
-static u32
-jffs2_scan_empty(u32 start_offset, struct part_info *part)
-{
-       char *max = (char *)(part->offset + part->size - sizeof(struct jffs2_raw_inode));
-       char *offset = (char *)(part->offset + start_offset);
-       u32 off;
-
-       while (offset < max &&
-              *(u32*)get_fl_mem((u32)offset, sizeof(u32), &off) == 0xFFFFFFFF) {
-               offset += sizeof(u32);
-               /* return if spinning is due */
-               if (((u32)offset & ((1 << SPIN_BLKSIZE)-1)) == 0) break;
-       }
-
-       return (u32)offset - part->offset;
-}
-
 void
 jffs2_free_cache(struct part_info *part)
 {
@@ -564,6 +670,7 @@ jffs2_free_cache(struct part_info *part)
                pL = (struct b_lists *)part->jffs2_priv;
                free_nodes(&pL->frag);
                free_nodes(&pL->dir);
+               free(pL->readbuf);
                free(pL);
        }
 }
@@ -579,7 +686,7 @@ jffs_init_1pass_list(struct part_info *part)
                pL = (struct b_lists *)part->jffs2_priv;
 
                memset(pL, 0, sizeof(*pL));
-#ifdef CFG_JFFS2_SORT_FRAGMENTS
+#ifdef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
                pL->dir.listCompare = compare_dirents;
                pL->frag.listCompare = compare_inodes;
 #endif
@@ -597,10 +704,9 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
        u32 latestVersion = 0;
        uchar *lDest;
        uchar *src;
-       long ret;
        int i;
        u32 counter = 0;
-#ifdef CFG_JFFS2_SORT_FRAGMENTS
+#ifdef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
        /* Find file size before loading any data, so fragments that
         * start past the end of file can be ignored. A fragment
         * that is partially in the file is loaded, so extra data may
@@ -610,7 +716,7 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
         */
        for (b = pL->frag.listHead; b != NULL; b = b->next) {
                jNode = (struct jffs2_raw_inode *) get_fl_mem(b->offset,
-                       sizeof(struct jffs2_raw_inode), NULL);
+                       sizeof(struct jffs2_raw_inode), pL->readbuf);
                if ((inode == jNode->ino)) {
                        /* get actual file length from the newest node */
                        if (jNode->version >= latestVersion) {
@@ -618,13 +724,25 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
                                latestVersion = jNode->version;
                        }
                }
-               put_fl_mem(jNode);
+               put_fl_mem(jNode, pL->readbuf);
        }
+       /*
+        * If no destination is provided, we are done.
+        * Just return the total size.
+        */
+       if (!dest)
+               return totalSize;
 #endif
 
        for (b = pL->frag.listHead; b != NULL; b = b->next) {
-               jNode = (struct jffs2_raw_inode *) get_node_mem(b->offset);
-               if ((inode == jNode->ino)) {
+               /*
+                * Copy just the node and not the data at this point,
+                * since we don't yet know if we need this data.
+                */
+               jNode = (struct jffs2_raw_inode *)get_fl_mem(b->offset,
+                               sizeof(struct jffs2_raw_inode),
+                               pL->readbuf);
+               if (inode == jNode->ino) {
 #if 0
                        putLabeledWord("\r\n\r\nread_inode: totlen = ", jNode->totlen);
                        putLabeledWord("read_inode: inode = ", jNode->ino);
@@ -638,7 +756,7 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
                        putLabeledWord("read_inode: flags = ", jNode->flags);
 #endif
 
-#ifndef CFG_JFFS2_SORT_FRAGMENTS
+#ifndef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
                        /* get actual file length from the newest node */
                        if (jNode->version >= latestVersion) {
                                totalSize = jNode->isize;
@@ -647,10 +765,25 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
 #endif
 
                        if(dest) {
-                               src = ((uchar *) jNode) + sizeof(struct jffs2_raw_inode);
+                               /*
+                                * Now that the inode has been checked,
+                                * read the entire inode, including data.
+                                */
+                               put_fl_mem(jNode, pL->readbuf);
+                               jNode = (struct jffs2_raw_inode *)
+                                       get_node_mem(b->offset, pL->readbuf);
+                               src = ((uchar *)jNode) +
+                                       sizeof(struct jffs2_raw_inode);
                                /* ignore data behind latest known EOF */
                                if (jNode->offset > totalSize) {
-                                       put_fl_mem(jNode);
+                                       put_fl_mem(jNode, pL->readbuf);
+                                       continue;
+                               }
+                               if (b->datacrc == CRC_UNKNOWN)
+                                       b->datacrc = data_crc(jNode) ?
+                                               CRC_OK : CRC_BAD;
+                               if (b->datacrc == CRC_BAD) {
+                                       put_fl_mem(jNode, pL->readbuf);
                                        continue;
                                }
 
@@ -661,37 +794,31 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
 #endif
                                switch (jNode->compr) {
                                case JFFS2_COMPR_NONE:
-                                       ret = (unsigned long) ldr_memcpy(lDest, src, jNode->dsize);
+                                       ldr_memcpy(lDest, src, jNode->dsize);
                                        break;
                                case JFFS2_COMPR_ZERO:
-                                       ret = 0;
                                        for (i = 0; i < jNode->dsize; i++)
                                                *(lDest++) = 0;
                                        break;
                                case JFFS2_COMPR_RTIME:
-                                       ret = 0;
                                        rtime_decompress(src, lDest, jNode->csize, jNode->dsize);
                                        break;
                                case JFFS2_COMPR_DYNRUBIN:
                                        /* this is slow but it works */
-                                       ret = 0;
                                        dynrubin_decompress(src, lDest, jNode->csize, jNode->dsize);
                                        break;
                                case JFFS2_COMPR_ZLIB:
-                                       ret = zlib_decompress(src, lDest, jNode->csize, jNode->dsize);
+                                       zlib_decompress(src, lDest, jNode->csize, jNode->dsize);
                                        break;
-#if defined(CONFIG_JFFS2_LZO_LZARI)
+#if defined(CONFIG_JFFS2_LZO)
                                case JFFS2_COMPR_LZO:
-                                       ret = lzo_decompress(src, lDest, jNode->csize, jNode->dsize);
-                                       break;
-                               case JFFS2_COMPR_LZARI:
-                                       ret = lzari_decompress(src, lDest, jNode->csize, jNode->dsize);
+                                       lzo_decompress(src, lDest, jNode->csize, jNode->dsize);
                                        break;
 #endif
                                default:
                                        /* unknown */
-                                       putLabeledWord("UNKOWN COMPRESSION METHOD = ", jNode->compr);
-                                       put_fl_mem(jNode);
+                                       putLabeledWord("UNKNOWN COMPRESSION METHOD = ", jNode->compr);
+                                       put_fl_mem(jNode, pL->readbuf);
                                        return -1;
                                        break;
                                }
@@ -699,11 +826,10 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest)
 
 #if 0
                        putLabeledWord("read_inode: totalSize = ", totalSize);
-                       putLabeledWord("read_inode: compr ret = ", ret);
 #endif
                }
                counter++;
-               put_fl_mem(jNode);
+               put_fl_mem(jNode, pL->readbuf);
        }
 
 #if 0
@@ -729,12 +855,12 @@ jffs2_1pass_find_inode(struct b_lists * pL, const char *name, u32 pino)
        counter = 0;
        /* we need to search all and return the inode with the highest version */
        for(b = pL->dir.listHead; b; b = b->next, counter++) {
-               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset);
+               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset,
+                                                               pL->readbuf);
                if ((pino == jDir->pino) && (len == jDir->nsize) &&
-                   (jDir->ino) &&      /* 0 for unlink */
                    (!strncmp((char *)jDir->name, name, len))) {        /* a match */
                        if (jDir->version < version) {
-                               put_fl_mem(jDir);
+                               put_fl_mem(jDir, pL->readbuf);
                                continue;
                        }
 
@@ -756,7 +882,7 @@ jffs2_1pass_find_inode(struct b_lists * pL, const char *name, u32 pino)
                putLabeledWord("b = ", (u32) b);
                putLabeledWord("counter = ", counter);
 #endif
-               put_fl_mem(jDir);
+               put_fl_mem(jDir, pL->readbuf);
        }
        return inode;
 }
@@ -827,9 +953,7 @@ static inline u32 dump_inode(struct b_lists * pL, struct jffs2_raw_dirent *d, st
        st.st_mtime = i->mtime;
        st.st_mode = i->mode;
        st.st_ino = i->ino;
-
-       /* neither dsize nor isize help us.. do it the long way */
-       st.st_size = jffs2_1pass_read_inode(pL, i->ino, NULL);
+       st.st_size = i->isize;
 
        dump_stat(&st, fname);
 
@@ -852,32 +976,68 @@ jffs2_1pass_list_inodes(struct b_lists * pL, u32 pino)
        struct jffs2_raw_dirent *jDir;
 
        for (b = pL->dir.listHead; b; b = b->next) {
-               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset);
-               if ((pino == jDir->pino) && (jDir->ino)) { /* ino=0 -> unlink */
+               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset,
+                                                               pL->readbuf);
+               if (pino == jDir->pino) {
                        u32 i_version = 0;
-                       struct jffs2_raw_inode ojNode;
                        struct jffs2_raw_inode *jNode, *i = NULL;
-                       struct b_node *b2 = pL->frag.listHead;
+                       struct b_node *b2;
+
+#ifdef CONFIG_SYS_JFFS2_SORT_FRAGMENTS
+                       /* Check for more recent versions of this file */
+                       int match;
+                       do {
+                               struct b_node *next = b->next;
+                               struct jffs2_raw_dirent *jDirNext;
+                               if (!next)
+                                       break;
+                               jDirNext = (struct jffs2_raw_dirent *)
+                                       get_node_mem(next->offset, NULL);
+                               match = jDirNext->pino == jDir->pino &&
+                                       jDirNext->nsize == jDir->nsize &&
+                                       strncmp((char *)jDirNext->name,
+                                               (char *)jDir->name,
+                                               jDir->nsize) == 0;
+                               if (match) {
+                                       /* Use next. It is more recent */
+                                       b = next;
+                                       /* Update buffer with the new info */
+                                       *jDir = *jDirNext;
+                               }
+                               put_fl_mem(jDirNext, NULL);
+                       } while (match);
+#endif
+                       if (jDir->ino == 0) {
+                               /* Deleted file */
+                               put_fl_mem(jDir, pL->readbuf);
+                               continue;
+                       }
 
-                       while (b2) {
+                       for (b2 = pL->frag.listHead; b2; b2 = b2->next) {
                                jNode = (struct jffs2_raw_inode *)
-                                       get_fl_mem(b2->offset, sizeof(ojNode), &ojNode);
-                               if (jNode->ino == jDir->ino && jNode->version >= i_version) {
+                                       get_fl_mem(b2->offset, sizeof(*jNode),
+                                                  NULL);
+                               if (jNode->ino == jDir->ino &&
+                                   jNode->version >= i_version) {
+                                       i_version = jNode->version;
                                        if (i)
-                                               put_fl_mem(i);
+                                               put_fl_mem(i, NULL);
 
                                        if (jDir->type == DT_LNK)
-                                               i = get_node_mem(b2->offset);
+                                               i = get_node_mem(b2->offset,
+                                                                NULL);
                                        else
-                                               i = get_fl_mem(b2->offset, sizeof(*i), NULL);
+                                               i = get_fl_mem(b2->offset,
+                                                              sizeof(*i),
+                                                              NULL);
                                }
-                               b2 = b2->next;
+                               put_fl_mem(jNode, NULL);
                        }
 
                        dump_inode(pL, jDir, i);
-                       put_fl_mem(i);
+                       put_fl_mem(i, NULL);
                }
-               put_fl_mem(jDir);
+               put_fl_mem(jDir, pL->readbuf);
        }
        return pino;
 }
@@ -955,10 +1115,11 @@ jffs2_1pass_resolve_inode(struct b_lists * pL, u32 ino)
 
        /* we need to search all and return the inode with the highest version */
        for(b = pL->dir.listHead; b; b = b->next) {
-               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset);
+               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset,
+                                                               pL->readbuf);
                if (ino == jDir->ino) {
                        if (jDir->version < version) {
-                               put_fl_mem(jDir);
+                               put_fl_mem(jDir, pL->readbuf);
                                continue;
                        }
 
@@ -975,7 +1136,7 @@ jffs2_1pass_resolve_inode(struct b_lists * pL, u32 ino)
                        jDirFoundPino = jDir->pino;
                        version = jDir->version;
                }
-               put_fl_mem(jDir);
+               put_fl_mem(jDir, pL->readbuf);
        }
        /* now we found the right entry again. (shoulda returned inode*) */
        if (jDirFoundType != DT_LNK)
@@ -984,7 +1145,8 @@ jffs2_1pass_resolve_inode(struct b_lists * pL, u32 ino)
        /* it's a soft link so we follow it again. */
        b2 = pL->frag.listHead;
        while (b2) {
-               jNode = (struct jffs2_raw_inode *) get_node_mem(b2->offset);
+               jNode = (struct jffs2_raw_inode *) get_node_mem(b2->offset,
+                                                               pL->readbuf);
                if (jNode->ino == jDirFoundIno) {
                        src = (unsigned char *)jNode + sizeof(struct jffs2_raw_inode);
 
@@ -996,11 +1158,11 @@ jffs2_1pass_resolve_inode(struct b_lists * pL, u32 ino)
 #endif
                        strncpy(tmp, (char *)src, jNode->dsize);
                        tmp[jNode->dsize] = '\0';
-                       put_fl_mem(jNode);
+                       put_fl_mem(jNode, pL->readbuf);
                        break;
                }
                b2 = b2->next;
-               put_fl_mem(jNode);
+               put_fl_mem(jNode, pL->readbuf);
        }
        /* ok so the name of the new file to find is in tmp */
        /* if it starts with a slash it is root based else shared dirs */
@@ -1094,6 +1256,167 @@ jffs2_1pass_rescan_needed(struct part_info *part)
        return 0;
 }
 
+#ifdef CONFIG_JFFS2_SUMMARY
+static u32 sum_get_unaligned32(u32 *ptr)
+{
+       u32 val;
+       u8 *p = (u8 *)ptr;
+
+       val = *p | (*(p + 1) << 8) | (*(p + 2) << 16) | (*(p + 3) << 24);
+
+       return __le32_to_cpu(val);
+}
+
+static u16 sum_get_unaligned16(u16 *ptr)
+{
+       u16 val;
+       u8 *p = (u8 *)ptr;
+
+       val = *p | (*(p + 1) << 8);
+
+       return __le16_to_cpu(val);
+}
+
+#define dbg_summary(...) do {} while (0);
+/*
+ * Process the stored summary information - helper function for
+ * jffs2_sum_scan_sumnode()
+ */
+
+static int jffs2_sum_process_sum_data(struct part_info *part, uint32_t offset,
+                               struct jffs2_raw_summary *summary,
+                               struct b_lists *pL)
+{
+       void *sp;
+       int i, pass;
+       void *ret;
+
+       for (pass = 0; pass < 2; pass++) {
+               sp = summary->sum;
+
+               for (i = 0; i < summary->sum_num; i++) {
+                       struct jffs2_sum_unknown_flash *spu = sp;
+                       dbg_summary("processing summary index %d\n", i);
+
+                       switch (sum_get_unaligned16(&spu->nodetype)) {
+                               case JFFS2_NODETYPE_INODE: {
+                               struct jffs2_sum_inode_flash *spi;
+                                       if (pass) {
+                                               spi = sp;
+
+                                               ret = insert_node(&pL->frag,
+                                                       (u32)part->offset +
+                                                       offset +
+                                                       sum_get_unaligned32(
+                                                               &spi->offset));
+                                               if (ret == NULL)
+                                                       return -1;
+                                       }
+
+                                       sp += JFFS2_SUMMARY_INODE_SIZE;
+
+                                       break;
+                               }
+                               case JFFS2_NODETYPE_DIRENT: {
+                                       struct jffs2_sum_dirent_flash *spd;
+                                       spd = sp;
+                                       if (pass) {
+                                               ret = insert_node(&pL->dir,
+                                                       (u32) part->offset +
+                                                       offset +
+                                                       sum_get_unaligned32(
+                                                               &spd->offset));
+                                               if (ret == NULL)
+                                                       return -1;
+                                       }
+
+                                       sp += JFFS2_SUMMARY_DIRENT_SIZE(
+                                                       spd->nsize);
+
+                                       break;
+                               }
+                               default : {
+                                       uint16_t nodetype = sum_get_unaligned16(
+                                                               &spu->nodetype);
+                                       printf("Unsupported node type %x found"
+                                                       " in summary!\n",
+                                                       nodetype);
+                                       if ((nodetype & JFFS2_COMPAT_MASK) ==
+                                                       JFFS2_FEATURE_INCOMPAT)
+                                               return -EIO;
+                                       return -EBADMSG;
+                               }
+                       }
+               }
+       }
+       return 0;
+}
+
+/* Process the summary node - called from jffs2_scan_eraseblock() */
+int jffs2_sum_scan_sumnode(struct part_info *part, uint32_t offset,
+                          struct jffs2_raw_summary *summary, uint32_t sumsize,
+                          struct b_lists *pL)
+{
+       struct jffs2_unknown_node crcnode;
+       int ret, ofs;
+       uint32_t crc;
+
+       ofs = part->sector_size - sumsize;
+
+       dbg_summary("summary found for 0x%08x at 0x%08x (0x%x bytes)\n",
+                   offset, offset + ofs, sumsize);
+
+       /* OK, now check for node validity and CRC */
+       crcnode.magic = JFFS2_MAGIC_BITMASK;
+       crcnode.nodetype = JFFS2_NODETYPE_SUMMARY;
+       crcnode.totlen = summary->totlen;
+       crc = crc32_no_comp(0, (uchar *)&crcnode, sizeof(crcnode)-4);
+
+       if (summary->hdr_crc != crc) {
+               dbg_summary("Summary node header is corrupt (bad CRC or "
+                               "no summary at all)\n");
+               goto crc_err;
+       }
+
+       if (summary->totlen != sumsize) {
+               dbg_summary("Summary node is corrupt (wrong erasesize?)\n");
+               goto crc_err;
+       }
+
+       crc = crc32_no_comp(0, (uchar *)summary,
+                       sizeof(struct jffs2_raw_summary)-8);
+
+       if (summary->node_crc != crc) {
+               dbg_summary("Summary node is corrupt (bad CRC)\n");
+               goto crc_err;
+       }
+
+       crc = crc32_no_comp(0, (uchar *)summary->sum,
+                       sumsize - sizeof(struct jffs2_raw_summary));
+
+       if (summary->sum_crc != crc) {
+               dbg_summary("Summary node data is corrupt (bad CRC)\n");
+               goto crc_err;
+       }
+
+       if (summary->cln_mkr)
+               dbg_summary("Summary : CLEANMARKER node \n");
+
+       ret = jffs2_sum_process_sum_data(part, offset, summary, pL);
+       if (ret == -EBADMSG)
+               return 0;
+       if (ret)
+               return ret;             /* real error */
+
+       return 1;
+
+crc_err:
+       putstr("Summary node crc error, skipping summary information.\n");
+
+       return 0;
+}
+#endif /* CONFIG_JFFS2_SUMMARY */
+
 #ifdef DEBUG_FRAGMENTS
 static void
 dump_fragments(struct b_lists *pL)
@@ -1135,7 +1458,8 @@ dump_dirents(struct b_lists *pL)
        putstr("\r\n\r\n******The directory Entries******\r\n");
        b = pL->dir.listHead;
        while (b) {
-               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset);
+               jDir = (struct jffs2_raw_dirent *) get_node_mem(b->offset,
+                                                               pL->readbuf);
                putstr("\r\n");
                putnstr(jDir->name, jDir->nsize);
                putLabeledWord("\r\n\tbuild_list: magic = ", jDir->magic);
@@ -1151,23 +1475,36 @@ dump_dirents(struct b_lists *pL)
                putLabeledWord("\tbuild_list: name_crc = ", jDir->name_crc);
                putLabeledWord("\tbuild_list: offset = ", b->offset);   /* FIXME: ? [RS] */
                b = b->next;
-               put_fl_mem(jDir);
+               put_fl_mem(jDir, pL->readbuf);
        }
 }
 #endif
 
+#define DEFAULT_EMPTY_SCAN_SIZE        4096
+
+static inline uint32_t EMPTY_SCAN_SIZE(uint32_t sector_size)
+{
+       if (sector_size < DEFAULT_EMPTY_SCAN_SIZE)
+               return sector_size;
+       else
+               return DEFAULT_EMPTY_SCAN_SIZE;
+}
+
 static u32
 jffs2_1pass_build_lists(struct part_info * part)
 {
        struct b_lists *pL;
        struct jffs2_unknown_node *node;
-       u32 offset, oldoffset = 0;
-       u32 max = part->size - sizeof(struct jffs2_raw_inode);
-       u32 counter = 0;
+       u32 nr_sectors;
+       u32 i;
        u32 counter4 = 0;
        u32 counterF = 0;
        u32 counterN = 0;
+       u32 max_totlen = 0;
+       u32 buf_size = DEFAULT_EMPTY_SCAN_SIZE;
+       char *buf;
 
+       nr_sectors = lldiv(part->size, part->sector_size);
        /* turn off the lcd.  Refreshing the lcd adds 50% overhead to the */
        /* jffs2 list building enterprise nope.  in newer versions the overhead is */
        /* only about 5 %.  not enough to inconvenience people for. */
@@ -1176,69 +1513,259 @@ jffs2_1pass_build_lists(struct part_info * part)
        /* if we are building a list we need to refresh the cache. */
        jffs_init_1pass_list(part);
        pL = (struct b_lists *)part->jffs2_priv;
-       offset = 0;
+       buf = malloc(buf_size);
        puts ("Scanning JFFS2 FS:   ");
 
        /* start at the beginning of the partition */
-       while (offset < max) {
-               if ((oldoffset >> SPIN_BLKSIZE) != (offset >> SPIN_BLKSIZE)) {
-                       printf("\b\b%c ", spinner[counter++ % sizeof(spinner)]);
-                       oldoffset = offset;
-               }
+       for (i = 0; i < nr_sectors; i++) {
+               uint32_t sector_ofs = i * part->sector_size;
+               uint32_t buf_ofs = sector_ofs;
+               uint32_t buf_len;
+               uint32_t ofs, prevofs;
+#ifdef CONFIG_JFFS2_SUMMARY
+               struct jffs2_sum_marker *sm;
+               void *sumptr = NULL;
+               uint32_t sumlen;
+               int ret;
+#endif
 
                WATCHDOG_RESET();
 
-               node = (struct jffs2_unknown_node *) get_node_mem((u32)part->offset + offset);
-               if (node->magic == JFFS2_MAGIC_BITMASK && hdr_crc(node)) {
+#ifdef CONFIG_JFFS2_SUMMARY
+               buf_len = sizeof(*sm);
+
+               /* Read as much as we want into the _end_ of the preallocated
+                * buffer
+                */
+               get_fl_mem(part->offset + sector_ofs + part->sector_size -
+                               buf_len, buf_len, buf + buf_size - buf_len);
+
+               sm = (void *)buf + buf_size - sizeof(*sm);
+               if (sm->magic == JFFS2_SUM_MAGIC) {
+                       sumlen = part->sector_size - sm->offset;
+                       sumptr = buf + buf_size - sumlen;
+
+                       /* Now, make sure the summary itself is available */
+                       if (sumlen > buf_size) {
+                               /* Need to kmalloc for this. */
+                               sumptr = malloc(sumlen);
+                               if (!sumptr) {
+                                       putstr("Can't get memory for summary "
+                                                       "node!\n");
+                                       free(buf);
+                                       jffs2_free_cache(part);
+                                       return 0;
+                               }
+                               memcpy(sumptr + sumlen - buf_len, buf +
+                                               buf_size - buf_len, buf_len);
+                       }
+                       if (buf_len < sumlen) {
+                               /* Need to read more so that the entire summary
+                                * node is present
+                                */
+                               get_fl_mem(part->offset + sector_ofs +
+                                               part->sector_size - sumlen,
+                                               sumlen - buf_len, sumptr);
+                       }
+               }
+
+               if (sumptr) {
+                       ret = jffs2_sum_scan_sumnode(part, sector_ofs, sumptr,
+                                       sumlen, pL);
+
+                       if (buf_size && sumlen > buf_size)
+                               free(sumptr);
+                       if (ret < 0) {
+                               free(buf);
+                               jffs2_free_cache(part);
+                               return 0;
+                       }
+                       if (ret)
+                               continue;
+
+               }
+#endif /* CONFIG_JFFS2_SUMMARY */
+
+               buf_len = EMPTY_SCAN_SIZE(part->sector_size);
+
+               get_fl_mem((u32)part->offset + buf_ofs, buf_len, buf);
+
+               /* We temporarily use 'ofs' as a pointer into the buffer/jeb */
+               ofs = 0;
+
+               /* Scan only 4KiB of 0xFF before declaring it's empty */
+               while (ofs < EMPTY_SCAN_SIZE(part->sector_size) &&
+                               *(uint32_t *)(&buf[ofs]) == 0xFFFFFFFF)
+                       ofs += 4;
+
+               if (ofs == EMPTY_SCAN_SIZE(part->sector_size))
+                       continue;
+
+               ofs += sector_ofs;
+               prevofs = ofs - 1;
+
+       scan_more:
+               while (ofs < sector_ofs + part->sector_size) {
+                       if (ofs == prevofs) {
+                               printf("offset %08x already seen, skip\n", ofs);
+                               ofs += 4;
+                               counter4++;
+                               continue;
+                       }
+                       prevofs = ofs;
+                       if (sector_ofs + part->sector_size <
+                                       ofs + sizeof(*node))
+                               break;
+                       if (buf_ofs + buf_len < ofs + sizeof(*node)) {
+                               buf_len = min_t(uint32_t, buf_size, sector_ofs
+                                               + part->sector_size - ofs);
+                               get_fl_mem((u32)part->offset + ofs, buf_len,
+                                          buf);
+                               buf_ofs = ofs;
+                       }
+
+                       node = (struct jffs2_unknown_node *)&buf[ofs-buf_ofs];
+
+                       if (*(uint32_t *)(&buf[ofs-buf_ofs]) == 0xffffffff) {
+                               uint32_t inbuf_ofs;
+                               uint32_t scan_end;
+
+                               ofs += 4;
+                               scan_end = min_t(uint32_t, EMPTY_SCAN_SIZE(
+                                                       part->sector_size)/8,
+                                                       buf_len);
+                       more_empty:
+                               inbuf_ofs = ofs - buf_ofs;
+                               while (inbuf_ofs < scan_end) {
+                                       if (*(uint32_t *)(&buf[inbuf_ofs]) !=
+                                                       0xffffffff)
+                                               goto scan_more;
+
+                                       inbuf_ofs += 4;
+                                       ofs += 4;
+                               }
+                               /* Ran off end. */
+
+                               /* See how much more there is to read in this
+                                * eraseblock...
+                                */
+                               buf_len = min_t(uint32_t, buf_size,
+                                               sector_ofs +
+                                               part->sector_size - ofs);
+                               if (!buf_len) {
+                                       /* No more to read. Break out of main
+                                        * loop without marking this range of
+                                        * empty space as dirty (because it's
+                                        * not)
+                                        */
+                                       break;
+                               }
+                               scan_end = buf_len;
+                               get_fl_mem((u32)part->offset + ofs, buf_len,
+                                          buf);
+                               buf_ofs = ofs;
+                               goto more_empty;
+                       }
+                       if (node->magic != JFFS2_MAGIC_BITMASK ||
+                                       !hdr_crc(node)) {
+                               ofs += 4;
+                               counter4++;
+                               continue;
+                       }
+                       if (ofs + node->totlen >
+                                       sector_ofs + part->sector_size) {
+                               ofs += 4;
+                               counter4++;
+                               continue;
+                       }
                        /* if its a fragment add it */
-                       if (node->nodetype == JFFS2_NODETYPE_INODE &&
-                                   inode_crc((struct jffs2_raw_inode *) node) &&
-                                   data_crc((struct jffs2_raw_inode *) node)) {
+                       switch (node->nodetype) {
+                       case JFFS2_NODETYPE_INODE:
+                               if (buf_ofs + buf_len < ofs + sizeof(struct
+                                                       jffs2_raw_inode)) {
+                                       get_fl_mem((u32)part->offset + ofs,
+                                                  buf_len, buf);
+                                       buf_ofs = ofs;
+                                       node = (void *)buf;
+                               }
+                               if (!inode_crc((struct jffs2_raw_inode *) node))
+                                      break;
+
                                if (insert_node(&pL->frag, (u32) part->offset +
-                                               offset) == NULL) {
-                                       put_fl_mem(node);
+                                               ofs) == NULL) {
+                                       free(buf);
+                                       jffs2_free_cache(part);
                                        return 0;
                                }
-                       } else if (node->nodetype == JFFS2_NODETYPE_DIRENT &&
-                                  dirent_crc((struct jffs2_raw_dirent *) node)  &&
-                                  dirent_name_crc((struct jffs2_raw_dirent *) node)) {
+                               if (max_totlen < node->totlen)
+                                       max_totlen = node->totlen;
+                               break;
+                       case JFFS2_NODETYPE_DIRENT:
+                               if (buf_ofs + buf_len < ofs + sizeof(struct
+                                                       jffs2_raw_dirent) +
+                                                       ((struct
+                                                        jffs2_raw_dirent *)
+                                                       node)->nsize) {
+                                       get_fl_mem((u32)part->offset + ofs,
+                                                  buf_len, buf);
+                                       buf_ofs = ofs;
+                                       node = (void *)buf;
+                               }
+
+                               if (!dirent_crc((struct jffs2_raw_dirent *)
+                                                       node) ||
+                                               !dirent_name_crc(
+                                                       (struct
+                                                        jffs2_raw_dirent *)
+                                                       node))
+                                       break;
                                if (! (counterN%100))
                                        puts ("\b\b.  ");
                                if (insert_node(&pL->dir, (u32) part->offset +
-                                               offset) == NULL) {
-                                       put_fl_mem(node);
+                                               ofs) == NULL) {
+                                       free(buf);
+                                       jffs2_free_cache(part);
                                        return 0;
                                }
+                               if (max_totlen < node->totlen)
+                                       max_totlen = node->totlen;
                                counterN++;
-                       } else if (node->nodetype == JFFS2_NODETYPE_CLEANMARKER) {
+                               break;
+                       case JFFS2_NODETYPE_CLEANMARKER:
                                if (node->totlen != sizeof(struct jffs2_unknown_node))
                                        printf("OOPS Cleanmarker has bad size "
-                                               "%d != %d\n", node->totlen,
+                                               "%d != %zu\n",
+                                               node->totlen,
                                                sizeof(struct jffs2_unknown_node));
-                       } else if (node->nodetype == JFFS2_NODETYPE_PADDING) {
+                               break;
+                       case JFFS2_NODETYPE_PADDING:
                                if (node->totlen < sizeof(struct jffs2_unknown_node))
                                        printf("OOPS Padding has bad size "
-                                               "%d < %d\n", node->totlen,
+                                               "%d < %zu\n",
+                                               node->totlen,
                                                sizeof(struct jffs2_unknown_node));
-                       } else {
-                               printf("Unknown node type: %x len %d "
-                                       "offset 0x%x\n", node->nodetype,
-                                       node->totlen, offset);
+                               break;
+                       case JFFS2_NODETYPE_SUMMARY:
+                               break;
+                       default:
+                               printf("Unknown node type: %x len %d offset 0x%x\n",
+                                       node->nodetype,
+                                       node->totlen, ofs);
                        }
-                       offset += ((node->totlen + 3) & ~3);
+                       ofs += ((node->totlen + 3) & ~3);
                        counterF++;
-               } else if (node->magic == JFFS2_EMPTY_BITMASK &&
-                          node->nodetype == JFFS2_EMPTY_BITMASK) {
-                       offset = jffs2_scan_empty(offset, part);
-               } else {        /* if we know nothing, we just step and look. */
-                       offset += 4;
-                       counter4++;
                }
-/*             printf("unknown node magic %4.4x %4.4x @ %lx\n", node->magic, node->nodetype, (unsigned long)node); */
-               put_fl_mem(node);
        }
 
+       free(buf);
        putstr("\b\b done.\r\n");               /* close off the dots */
+
+       /* We don't care if malloc failed - then each read operation will
+        * allocate its own buffer as necessary (NAND) or will read directly
+        * from flash (NOR).
+        */
+       pL->readbuf = malloc(max_totlen);
+
        /* turn the lcd back on. */
        /* splash(); */
 
@@ -1392,5 +1919,3 @@ jffs2_1pass_info(struct part_info * part)
        }
        return 1;
 }
-
-#endif