]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
mxs: fix abuse of RTC_CTRL_FORCE_UPDATE
authorLothar Waßmann <LW@KARO-electronics.de>
Mon, 15 Jul 2013 09:17:47 +0000 (11:17 +0200)
committerLothar Waßmann <LW@KARO-electronics.de>
Mon, 15 Jul 2013 09:17:47 +0000 (11:17 +0200)
1. RTC_CTRL_FORCE_UPDATE is self clearing. There is no need to clear
   it manually.
2. RTC_CTRL_FORCE_UPDATE instructs the HW to read back the shadow
   register from the HW, not the other way round, as the original code
   seems to assume.

arch/arm/cpu/arm926ejs/mxs/spl_power_init.c

index 362df4cb665987e0a658018e115bd05784c36cf8..490cfbba914abff6ac5bb6ad7bb7c5d255f349d3 100644 (file)
@@ -137,10 +137,10 @@ static void mxs_power_clear_auto_restart(void)
 
        setbits_le32(&rtc_regs->hw_rtc_persistent0,
                        RTC_PERSISTENT0_AUTO_RESTART);
-       writel(RTC_CTRL_FORCE_UPDATE, &rtc_regs->hw_rtc_ctrl_set);
-       writel(RTC_CTRL_FORCE_UPDATE, &rtc_regs->hw_rtc_ctrl_clr);
        while (readl(&rtc_regs->hw_rtc_stat) & RTC_STAT_NEW_REGS_MASK)
                ;
+
+       writel(RTC_CTRL_FORCE_UPDATE, &rtc_regs->hw_rtc_ctrl_set);
        while (readl(&rtc_regs->hw_rtc_stat) & RTC_STAT_STALE_REGS_MASK)
                ;
 }