]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
drivers/sysreset: fix check of address returned by dev_get_addr()
authorLothar Waßmann <LW@KARO-electronics.de>
Mon, 13 Mar 2017 14:54:56 +0000 (15:54 +0100)
committerLothar Waßmann <LW@KARO-electronics.de>
Mon, 13 Mar 2017 15:36:38 +0000 (16:36 +0100)
dev_get_addr() returns either a valid I/O address or FDT_ADDR_T_NONE
(which happens to be defined as -1) but not NULL in case of error!

drivers/sysreset/sysreset_snapdragon.c

index a6cabfb8b012ab18e15fe87da71b3a0eb76120cd..47f9d619bd7287919d04315ab8dabac2cd3bbfdb 100644 (file)
@@ -17,7 +17,8 @@ DECLARE_GLOBAL_DATA_PTR;
 static int msm_sysreset_request(struct udevice *dev, enum sysreset_t type)
 {
        phys_addr_t addr = dev_get_addr(dev);
-       if (!addr)
+
+       if (addr == FDT_ADDR_T_NONE)
                return -EINVAL;
        writel(0, addr);
        return -EINPROGRESS;