]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
cmd_extX: use common get_device_and_partition function
authorRob Herring <rob.herring@calxeda.com>
Thu, 23 Aug 2012 11:31:46 +0000 (11:31 +0000)
committerTom Rini <trini@ti.com>
Tue, 25 Sep 2012 21:46:55 +0000 (14:46 -0700)
Convert ext2/4 load, ls, and write functions to use common device and
partition parsing function. With the common function "dev:part" can come
from the environment and a '-' can be used in that case.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
common/cmd_ext4.c
common/cmd_ext_common.c
fs/ext4/dev.c
fs/ext4/ext4_common.h
fs/ext4/ext4fs.c
include/ext4fs.h
include/ext_common.h

index e92c02ff64014246ce9989c112936735db0229a3..48f9ba314cca44a771ad6c35ed95f9e21e2b5cd5 100644 (file)
 #include <usb.h>
 #endif
 
-#if !defined(CONFIG_DOS_PARTITION) && !defined(CONFIG_EFI_PARTITION)
-#error DOS or EFI partition support must be selected
-#endif
-
-uint64_t total_sector;
-uint64_t part_offset;
-#if defined(CONFIG_CMD_EXT4_WRITE)
-static uint64_t part_size;
-static uint16_t cur_part = 1;
-#endif
-
-#define DOS_PART_MAGIC_OFFSET          0x1fe
-#define DOS_FS_TYPE_OFFSET             0x36
-#define DOS_FS32_TYPE_OFFSET           0x52
-
 int do_ext4_load(cmd_tbl_t *cmdtp, int flag, int argc,
                                                char *const argv[])
 {
@@ -89,77 +74,24 @@ int do_ext4_ls(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 }
 
 #if defined(CONFIG_CMD_EXT4_WRITE)
-static int ext4_register_device(block_dev_desc_t *dev_desc, int part_no)
-{
-       unsigned char buffer[SECTOR_SIZE];
-       disk_partition_t info;
-
-       if (!dev_desc->block_read)
-               return -1;
-
-       /* check if we have a MBR (on floppies we have only a PBR) */
-       if (dev_desc->block_read(dev_desc->dev, 0, 1, (ulong *) buffer) != 1) {
-               printf("** Can't read from device %d **\n", dev_desc->dev);
-               return -1;
-       }
-       if (buffer[DOS_PART_MAGIC_OFFSET] != 0x55 ||
-           buffer[DOS_PART_MAGIC_OFFSET + 1] != 0xaa) {
-               /* no signature found */
-               return -1;
-       }
-
-       /* First we assume there is a MBR */
-       if (!get_partition_info(dev_desc, part_no, &info)) {
-               part_offset = info.start;
-               cur_part = part_no;
-               part_size = info.size;
-       } else if ((strncmp((char *)&buffer[DOS_FS_TYPE_OFFSET],
-                           "FAT", 3) == 0) || (strncmp((char *)&buffer
-                                                       [DOS_FS32_TYPE_OFFSET],
-                                                       "FAT32", 5) == 0)) {
-               /* ok, we assume we are on a PBR only */
-               cur_part = 1;
-               part_offset = 0;
-       } else {
-               printf("** Partition %d not valid on device %d **\n",
-                      part_no, dev_desc->dev);
-               return -1;
-       }
-
-       return 0;
-}
-
 int do_ext4_write(cmd_tbl_t *cmdtp, int flag, int argc,
                                char *const argv[])
 {
        const char *filename = "/";
-       int part_length;
-       unsigned long part = 1;
-       int dev;
-       char *ep;
+       int dev, part;
        unsigned long ram_address;
        unsigned long file_size;
        disk_partition_t info;
-       struct ext_filesystem *fs;
+       block_dev_desc_t *dev_desc;
 
        if (argc < 6)
                return cmd_usage(cmdtp);
 
-       dev = (int)simple_strtoul(argv[2], &ep, 16);
-       ext4_dev_desc = get_dev(argv[1], dev);
-       if (ext4_dev_desc == NULL) {
-               printf("Block device %s %d not supported\n", argv[1], dev);
+       part = get_device_and_partition(argv[1], argv[2], &dev_desc, &info);
+       if (part < 0)
                return 1;
-       }
 
-       fs = get_fs();
-       if (*ep) {
-               if (*ep != ':') {
-                       puts("Invalid boot device, use `dev[:part]'\n");
-                       goto fail;
-               }
-               part = simple_strtoul(++ep, NULL, 16);
-       }
+       dev = dev_desc->dev;
 
        /* get the filename */
        filename = argv[3];
@@ -171,30 +103,10 @@ int do_ext4_write(cmd_tbl_t *cmdtp, int flag, int argc,
        file_size = simple_strtoul(argv[5], NULL, 10);
 
        /* set the device as block device */
-       part_length = ext4fs_set_blk_dev(ext4_dev_desc, part);
-       if (part_length == 0) {
-               printf("Bad partition - %s %d:%lu\n", argv[1], dev, part);
-               goto fail;
-       }
-
-       /* register the device and partition */
-       if (ext4_register_device(ext4_dev_desc, part) != 0) {
-               printf("Unable to use %s %d:%lu for fattable\n",
-                      argv[1], dev, part);
-               goto fail;
-       }
-
-       /* get the partition information */
-       if (!get_partition_info(ext4_dev_desc, part, &info)) {
-               total_sector = (info.size * info.blksz) / SECTOR_SIZE;
-               fs->total_sect = total_sector;
-       } else {
-               printf("error : get partition info\n");
-               goto fail;
-       }
+       ext4fs_set_blk_dev(dev_desc, &info);
 
        /* mount the filesystem */
-       if (!ext4fs_mount(part_length)) {
+       if (!ext4fs_mount(info.size)) {
                printf("Bad ext4 partition %s %d:%lu\n", argv[1], dev, part);
                goto fail;
        }
index 8972ccce2867b61963113b2299b4b03b0d2588bd..7d26944ead2c77a71aa45529c91d4c71133c25a2 100644 (file)
@@ -68,13 +68,11 @@ int do_ext_load(cmd_tbl_t *cmdtp, int flag, int argc,
                                                char *const argv[])
 {
        char *filename = NULL;
-       char *ep;
-       int dev;
-       unsigned long part = 1;
+       int dev, part;
        ulong addr = 0;
-       ulong part_length;
        int filelen;
        disk_partition_t info;
+       block_dev_desc_t *dev_desc;
        char buf[12];
        unsigned long count;
        const char *addr_str;
@@ -110,50 +108,19 @@ int do_ext_load(cmd_tbl_t *cmdtp, int flag, int argc,
                return 1;
        }
 
-       dev = (int)simple_strtoul(argv[2], &ep, 16);
-       ext4_dev_desc = get_dev(argv[1], dev);
-       if (ext4_dev_desc == NULL) {
-               printf("** Block device %s %d not supported\n", argv[1], dev);
+       part = get_device_and_partition(argv[1], argv[2], &dev_desc, &info);
+       if (part < 0)
                return 1;
-       }
 
-       if (*ep) {
-               if (*ep != ':') {
-                       puts("** Invalid boot device, use `dev[:part]' **\n");
-                       goto fail;
-               }
-               part = simple_strtoul(++ep, NULL, 16);
-       }
+       dev = dev_desc->dev;
+       printf("Loading file \"%s\" from %s device %d%c%c\n",
+               filename, argv[1], dev,
+               part ? ':' : ' ', part ? part + '0' : ' ');
 
-       if (part != 0) {
-               if (get_partition_info(ext4_dev_desc, part, &info)) {
-                       printf("** Bad partition %lu **\n", part);
-                       goto fail;
-               }
-
-               if (strncmp((char *)info.type, BOOT_PART_TYPE,
-                           strlen(BOOT_PART_TYPE)) != 0) {
-                       printf("** Invalid partition type \"%s\""
-                              " (expect \"" BOOT_PART_TYPE "\")\n", info.type);
-                       goto fail;
-               }
-               printf("Loading file \"%s\" "
-                      "from %s device %d:%lu %s\n",
-                      filename, argv[1], dev, part, info.name);
-       } else {
-               printf("Loading file \"%s\" from %s device %d\n",
-                      filename, argv[1], dev);
-       }
+       ext4fs_set_blk_dev(dev_desc, &info);
 
-       part_length = ext4fs_set_blk_dev(ext4_dev_desc, part);
-       if (part_length == 0) {
-               printf("**Bad partition - %s %d:%lu **\n", argv[1], dev, part);
-               ext4fs_close();
-               goto fail;
-       }
-
-       if (!ext4fs_mount(part_length)) {
-               printf("** Bad ext2 partition or disk - %s %d:%lu **\n",
+       if (!ext4fs_mount(info.size)) {
+               printf("** Bad ext2 partition or disk - %s %d:%d **\n",
                       argv[1], dev, part);
                ext4fs_close();
                goto fail;
@@ -169,7 +136,7 @@ int do_ext_load(cmd_tbl_t *cmdtp, int flag, int argc,
                filelen = count;
 
        if (ext4fs_read((char *)addr, filelen) != filelen) {
-               printf("** Unable to read \"%s\" from %s %d:%lu **\n",
+               printf("** Unable to read \"%s\" from %s %d:%d **\n",
                       filename, argv[1], dev, part);
                ext4fs_close();
                goto fail;
@@ -192,41 +159,25 @@ int do_ext_ls(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 {
        const char *filename = "/";
        int dev;
-       unsigned long part = 1;
-       char *ep;
-       int part_length;
-       if (argc < 3)
-               return cmd_usage(cmdtp);
-
-       dev = (int)simple_strtoul(argv[2], &ep, 16);
+       int part;
+       block_dev_desc_t *dev_desc;
+       disk_partition_t info;
 
-       ext4_dev_desc = get_dev(argv[1], dev);
+       if (argc < 2)
+               return cmd_usage(cmdtp);
 
-       if (ext4_dev_desc == NULL) {
-               printf("\n** Block device %s %d not supported\n", argv[1], dev);
+       part = get_device_and_partition(argv[1], argv[2], &dev_desc, &info);
+       if (part < 0)
                return 1;
-       }
-
-       if (*ep) {
-               if (*ep != ':') {
-                       puts("\n** Invalid boot device, use `dev[:part]' **\n");
-                       goto fail;
-               }
-               part = simple_strtoul(++ep, NULL, 16);
-       }
 
        if (argc == 4)
                filename = argv[3];
 
-       part_length = ext4fs_set_blk_dev(ext4_dev_desc, part);
-       if (part_length == 0) {
-               printf("** Bad partition - %s %d:%lu **\n", argv[1], dev, part);
-               ext4fs_close();
-               goto fail;
-       }
+       dev = dev_desc->dev;
+       ext4fs_set_blk_dev(dev_desc, &info);
 
-       if (!ext4fs_mount(part_length)) {
-               printf("** Bad ext2 partition or disk - %s %d:%lu **\n",
+       if (!ext4fs_mount(info.size)) {
+               printf("** Bad ext2 partition or disk - %s %d:%d **\n",
                       argv[1], dev, part);
                ext4fs_close();
                goto fail;
index 9e85228edacf8b5c5ae72dec57008d53ad9e09b4..1596a92b9ada611fd6889741f5b5d421b290f0fc 100644 (file)
 
 #include <common.h>
 #include <config.h>
+#include <ext4fs.h>
 #include <ext_common.h>
 
+unsigned long part_offset;
+
 static block_dev_desc_t *ext4fs_block_dev_desc;
-static disk_partition_t part_info;
+static disk_partition_t *part_info;
 
-int ext4fs_set_blk_dev(block_dev_desc_t *rbdd, int part)
+void ext4fs_set_blk_dev(block_dev_desc_t *rbdd, disk_partition_t *info)
 {
        ext4fs_block_dev_desc = rbdd;
-
-       if (part == 0) {
-               /* disk doesn't use partition table */
-               part_info.start = 0;
-               part_info.size = rbdd->lba;
-               part_info.blksz = rbdd->blksz;
-       } else {
-               if (get_partition_info(ext4fs_block_dev_desc,
-                                       part, &part_info))
-                       return 0;
-       }
-       return part_info.size;
+       part_info = info;
+       part_offset = info->start;
+       get_fs()->total_sect = (info->size * info->blksz) / SECTOR_SIZE;
 }
 
 int ext4fs_devread(int sector, int byte_offset, int byte_len, char *buf)
@@ -68,7 +62,7 @@ int ext4fs_devread(int sector, int byte_offset, int byte_len, char *buf)
        /* Check partition boundaries */
        if ((sector < 0)
            || ((sector + ((byte_offset + byte_len - 1) >> SECTOR_BITS)) >=
-               part_info.size)) {
+               part_info->size)) {
                printf("%s read outside partition %d\n", __func__, sector);
                return 0;
        }
@@ -88,7 +82,7 @@ int ext4fs_devread(int sector, int byte_offset, int byte_len, char *buf)
                /* read first part which isn't aligned with start of sector */
                if (ext4fs_block_dev_desc->
                    block_read(ext4fs_block_dev_desc->dev,
-                               part_info.start + sector, 1,
+                               part_info->start + sector, 1,
                                (unsigned long *) sec_buf) != 1) {
                        printf(" ** ext2fs_devread() read error **\n");
                        return 0;
@@ -111,14 +105,14 @@ int ext4fs_devread(int sector, int byte_offset, int byte_len, char *buf)
 
                block_len = SECTOR_SIZE;
                ext4fs_block_dev_desc->block_read(ext4fs_block_dev_desc->dev,
-                                                 part_info.start + sector,
+                                                 part_info->start + sector,
                                                  1, (unsigned long *)p);
                memcpy(buf, p, byte_len);
                return 1;
        }
 
        if (ext4fs_block_dev_desc->block_read(ext4fs_block_dev_desc->dev,
-                                              part_info.start + sector,
+                                              part_info->start + sector,
                                               block_len / SECTOR_SIZE,
                                               (unsigned long *) buf) !=
                                               block_len / SECTOR_SIZE) {
@@ -134,7 +128,7 @@ int ext4fs_devread(int sector, int byte_offset, int byte_len, char *buf)
                /* read rest of data which are not in whole sector */
                if (ext4fs_block_dev_desc->
                    block_read(ext4fs_block_dev_desc->dev,
-                               part_info.start + sector, 1,
+                               part_info->start + sector, 1,
                                (unsigned long *) sec_buf) != 1) {
                        printf("* %s read error - last part\n", __func__);
                        return 0;
index 0af625db2babfe6cde046717d2689a2257a105f0..f7281341869724e18e27c8e9804ae7e3b9387a24 100644 (file)
@@ -62,7 +62,6 @@ static inline void *zalloc(size_t size)
        return p;
 }
 
-extern unsigned long part_offset;
 int ext4fs_read_inode(struct ext2_data *data, int ino,
                      struct ext2_inode *inode);
 int ext4fs_read_file(struct ext2fs_node *node, int pos,
index c366e6f0998842a93aa2dacbd7b2a4115cea5e7a..93dcb7e8face83e72adfcd54a5b2a2ff2181eddd 100644 (file)
@@ -43,7 +43,6 @@
 #include "ext4_common.h"
 
 int ext4fs_symlinknest;
-block_dev_desc_t *ext4_dev_desc;
 struct ext_filesystem ext_fs;
 
 struct ext_filesystem *get_fs(void)
index 6ad008c0dad2e3a4c3142b2b57329c75b7197ff9..b6eedde3180820ea2857d82f558fa18c30e95e89 100644 (file)
@@ -113,7 +113,6 @@ struct ext_filesystem {
        block_dev_desc_t *dev_desc;
 };
 
-extern block_dev_desc_t *ext4_dev_desc;
 extern struct ext2_data *ext4fs_root;
 extern struct ext2fs_node *ext4fs_file;
 
@@ -137,6 +136,6 @@ void ext4fs_close(void);
 int ext4fs_ls(const char *dirname);
 void ext4fs_free_node(struct ext2fs_node *node, struct ext2fs_node *currroot);
 int ext4fs_devread(int sector, int byte_offset, int byte_len, char *buf);
-int ext4fs_set_blk_dev(block_dev_desc_t *rbdd, int part);
+void ext4fs_set_blk_dev(block_dev_desc_t *rbdd, disk_partition_t *info);
 long int read_allocated_block(struct ext2_inode *inode, int fileblock);
 #endif
index 9b97522c853c84b9b4541e53742453716ca9f011..ce73857f8d813961d9fdf045136f64752e63cdad 100644 (file)
@@ -186,6 +186,8 @@ struct ext2_data {
        struct ext2fs_node diropen;
 };
 
+extern unsigned long part_offset;
+
 int do_ext2ls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]);
 int do_ext2load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]);
 int do_ext4_load(cmd_tbl_t *cmdtp, int flag, int argc,