]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
mxc_i2c: remove setting speed at each start
authorTroy Kisky <troy.kisky@boundarydevices.com>
Tue, 24 Apr 2012 17:33:27 +0000 (17:33 +0000)
committerHeiko Schocher <hs@denx.de>
Wed, 11 Jul 2012 08:54:52 +0000 (10:54 +0200)
Other then being very weird, this code was also wrong.
For example, say I set speed to 100K. I'll read back the speed
as 85937. But the speed is really 85937.5, so we I reset
the speed to 85937, I'll get 73660.7. After a couple of transactions
my speed is now exactly 68750 so it will remain there.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Acked-by: Marek Vasut <marex@denx.de>
Acked-by: Stefano Babic <sbabic@denx.de>
drivers/i2c/mxc_i2c.c

index 416ffeed00bc34dcde4cc40715ad61e37977a537..fc68062b1183340a1d2427b6576d31fd0ba7f411 100644 (file)
@@ -231,12 +231,6 @@ int i2c_imx_start(void)
        struct mxc_i2c_regs *i2c_regs = (struct mxc_i2c_regs *)I2C_BASE;
        unsigned int temp = 0;
        int result;
-       int speed = i2c_get_bus_speed();
-       u8 clk_idx = i2c_imx_get_clk(speed);
-       u8 idx = i2c_clk_div[clk_idx][1];
-
-       /* Store divider value */
-       writeb(idx, &i2c_regs->ifdr);
 
        /* Enable I2C controller */
        writeb(0, &i2c_regs->i2sr);