Fix performance issue

diff --git a/drivers/mmc/mxsmmc.c b/drivers/mmc/mxsmmc.c
index c0e8e0a31ba564b588ca68d463925ea5080c9dac..02e0ffef94a166376ba2630b60eff268c6b8d782 100644 (file)
--- a/drivers/mmc/mxsmmc.c
+++ b/drivers/mmc/mxsmmc.c
@@ -67,22 +67,19 @@ mxsmmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
        uint32_t data_count;
        uint32_t *data_ptr;
        uint32_t ctrl0;
+       const uint32_t busy_stat = SSP_STATUS_BUSY | SSP_STATUS_DATA_BUSY |
+               SSP_STATUS_CMD_BUSY;
 
        debug("MMC%d: CMD%d\n", mmc->block_dev.dev, cmd->cmdidx);
 
        /* Check bus busy */
        timeout = MXSMMC_MAX_TIMEOUT;
-       while (--timeout) {
-               udelay(1000);
-               reg = readl(&ssp_regs->hw_ssp_status);
-               if (!(reg &
-                       (SSP_STATUS_BUSY | SSP_STATUS_DATA_BUSY |
-                       SSP_STATUS_CMD_BUSY))) {
+       while ((reg = readl(&ssp_regs->hw_ssp_status)) & busy_stat) {
+               if (timeout-- <= 0)
                        break;
-               }
+               udelay(1000);
        }
-
-       if (!timeout) {
+       if (reg & busy_stat && readl(&ssp_regs->hw_ssp_status) & busy_stat) {
                printf("MMC%d: Bus busy timeout!\n", mmc->block_dev.dev);
                return TIMEOUT;
        }
@@ -149,8 +146,8 @@ mxsmmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
                if (!(reg & SSP_STATUS_CMD_BUSY))
                        break;
        }
-
-       if (!timeout) {
+       if ((reg & SSP_STATUS_CMD_BUSY) &&
+               (readl(&ssp_regs->hw_ssp_status) & SSP_STATUS_CMD_BUSY)) {
                printf("MMC%d: Command %d busy\n",
                        mmc->block_dev.dev, cmd->cmdidx);
                return TIMEOUT;
@@ -185,33 +182,37 @@ mxsmmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
 
        /* Process the data */
        data_count = data->blocksize * data->blocks;
-       timeout = MXSMMC_MAX_TIMEOUT;
+
+       timeout = get_timer(0);
        if (data->flags & MMC_DATA_READ) {
                data_ptr = (uint32_t *)data->dest;
-               while (data_count && --timeout) {
+               while (data_count) {
                        reg = readl(&ssp_regs->hw_ssp_status);
                        if (!(reg & SSP_STATUS_FIFO_EMPTY)) {
                                *data_ptr++ = readl(&ssp_regs->hw_ssp_data);
                                data_count -= 4;
-                               timeout = MXSMMC_MAX_TIMEOUT;
-                       } else
-                               udelay(1000);
+                               timeout = get_timer(0);
+                       } else if ((get_timer(timeout) > MXSMMC_MAX_TIMEOUT) &&
+                               (readl(&ssp_regs->hw_ssp_status) & SSP_STATUS_FIFO_EMPTY)) {
+                               break;
+                       }
                }
        } else {
                data_ptr = (uint32_t *)data->src;
-               timeout *= 100;
-               while (data_count && --timeout) {
+               while (data_count) {
                        reg = readl(&ssp_regs->hw_ssp_status);
                        if (!(reg & SSP_STATUS_FIFO_FULL)) {
                                writel(*data_ptr++, &ssp_regs->hw_ssp_data);
                                data_count -= 4;
-                               timeout = MXSMMC_MAX_TIMEOUT;
-                       } else
-                               udelay(1000);
+                               timeout = get_timer(0);
+                       } else if ((get_timer(timeout) > MXSMMC_MAX_TIMEOUT * 100) &&
+                               (readl(&ssp_regs->hw_ssp_status) & SSP_STATUS_FIFO_FULL)) {
+                                       break;
+                       }
                }
        }
 
-       if (!timeout) {
+       if (data_count) {
                printf("MMC%d: Data timeout with command %d (status 0x%08x)!\n",
                        mmc->block_dev.dev, cmd->cmdidx, reg);
                return COMM_ERR;
@@ -337,14 +338,6 @@ int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int))
        mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_8BIT |
                         MMC_MODE_HS_52MHz | MMC_MODE_HS;
 
-       /*
-        * SSPCLK = 480 * 18 / 29 / 1 = 297.731 MHz
-        * SSP bit rate = SSPCLK / (CLOCK_DIVIDE * (1 + CLOCK_RATE)),
-        * CLOCK_DIVIDE has to be an even value from 2 to 254, and
-        * CLOCK_RATE could be any integer from 0 to 255.
-        */
-       writel(CLKCTRL_SSP_DIV_FRAC_EN | 29, priv->clkctrl_ssp);
-
        mmc->f_min = 400000;
        mmc->f_max = mxc_get_clock(MXC_SSP0_CLK + id) * 1000 / 2;
        mmc->b_max = 0;