From: Simon Glass <sjg@chromium.org>
Date: Thu, 23 Oct 2014 03:37:03 +0000 (-0600)
Subject: dm: serial: ns16550: Correct logic for checking for character
X-Git-Tag: KARO-TXA5-2015-06-26~446^2~46
X-Git-Url: https://git.kernelconcepts.de/?p=karo-tx-uboot.git;a=commitdiff_plain;h=aea2be2012f474ddc9f372547e487ee74d4eb67a

dm: serial: ns16550: Correct logic for checking for character

There is a bug in the logic which checks for an available character. This
can cause invalid characters to be received - this was noticed on
beaglebone. Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@ti.com>
---

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 63a9ef6844..fe6cc26afe 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -253,7 +253,7 @@ static int ns16550_serial_getc(struct udevice *dev)
 {
 	struct NS16550 *const com_port = dev_get_priv(dev);
 
-	if (!serial_in(&com_port->lsr) & UART_LSR_DR)
+	if (!(serial_in(&com_port->lsr) & UART_LSR_DR))
 		return -EAGAIN;
 
 	return serial_in(&com_port->rbr);